Skip to content

fix: make spitfire compile on elixir 1.13#62

Merged
mhanberg merged 1 commit intoelixir-tools:mainfrom
zachdaniel:main
Jun 3, 2025
Merged

fix: make spitfire compile on elixir 1.13#62
mhanberg merged 1 commit intoelixir-tools:mainfrom
zachdaniel:main

Conversation

@zachdaniel
Copy link
Copy Markdown
Contributor

This is maybe a little silly, as spitfire doesn't support 1.13, but this change makes it compile on 1.13, which is useful for packages w/ older elixir version support to use igniter.

Would you be amenable to this? getsentry/sentry-elixir#876

@mhanberg
Copy link
Copy Markdown
Contributor

Can you remove the extraneous changes

@mhanberg
Copy link
Copy Markdown
Contributor

Will this actually compile on 1.13 if the elixir version constraint in mix.exs isn't changed?

@zachdaniel
Copy link
Copy Markdown
Contributor Author

AFAICT yes it will, it only validates that version when compiling your specific project.

@zachdaniel
Copy link
Copy Markdown
Contributor Author

I've removed the extraneous changes, had format-on-save on, sorry 😅

@zachdaniel
Copy link
Copy Markdown
Contributor Author

Yep, just a warning:

==> spitfire
warning: the dependency :spitfire requires Elixir "~> 1.15" but you are running on v1.13.4

@lukaszsamson
Copy link
Copy Markdown
Contributor

Does it make sense to add support for 1.13 when it’s reached EOL?

@zachdaniel
Copy link
Copy Markdown
Contributor Author

Not really, but it's blocking a PR elsewhere and I figured if it's essentially one if statement that it might be acceptable. A sentry igniter installer would be very nice to have 😅

getsentry/sentry-elixir#876

@mhanberg mhanberg merged commit 5eda84e into elixir-tools:main Jun 3, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants