Dynamically determine ICE agent's role #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICE agent's role should be dynamically determined based on who sends the offer first and whether any side is running ice-lite. See: https://www.w3.org/TR/webrtc/#ref-for-dfn-icerole-1
So far, we have been always setting ICE agent's role to controlled and we were counting on ICE role conflict resolution.
However, some implementations does not support role conflict resolution and rely on correct role determination. See pion/ice#359 (comment)
In such case, we will get stuck and never establish ICE connection.
This PR, removes hard-coded agent's role and dynamically determines it according to W3C spec linked above.