-
Notifications
You must be signed in to change notification settings - Fork 21
Add close/1. Handle DTLS close_notify alert #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 88.06% 87.70% -0.37%
==========================================
Files 50 50
Lines 2623 2684 +61
==========================================
+ Hits 2310 2354 +44
- Misses 313 330 +17
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
0cbfc51
to
2c37359
Compare
6675529
to
e9766cf
Compare
cd63edc
to
953101a
Compare
20002ce
to
a74f66d
Compare
1264224
to
0df50e4
Compare
This PR:
{:error, :invalid_state}
when called after closing peer connection. Calling close/1 will also sendclose_notify
DTLS alert to the other sideclose_notify
DTLS alert. This alert moves DTLS transport to the closed state but does not move peer connection, signaling or ice transport to the closed state. Peer connection that receivedclose_notify
DTLS alert can still do ice restart with a different peer. See: RTCPeerConnection does not move to the closed state when RTCDTLSTransport receives close_notify DTLS alert w3c/webrtc-pc#3053Resources:
closes elixir-webrtc/ex_ice#78