Initial standalone Recorder+Converter implementation #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from
ex_webrtc v0.8.1
Features
Breaking changes
Recorder
report
(and thereport.json
file) was changed tomanifest
(manifest.json
)add_tracks/2
now returns{:ok, manifest :: Recorder.manifest()}
manifest
contains only the parts relevant to the added tracks, and not the entire manifest of the RecorderConverter
ffmpeg
binary with the relevant libraries present inPATH
convert!/2
now acceptst:Converter.options/0
as the second argumentNon-breaking important changes
Recorder
end_tracks/2
that closes the relevant file handles and optionally schedules the S3 uploadConverter
convert!/2
can also acceptt:Recorder.manifest/0
as the first argument (e.g. the manifest returned byRecorder.end_tracks/2
)