fix: prevent showing notification errors for dev for known emoji reaction types #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
shuuji3/fix/prevent-debug-error-log-for-wellknown-reactions-types
branch
from
063a280 to
ab410a0
Compare
patak-dev
approved these changes
Mar 19, 2024
patak-dev
deleted the
shuuji3/fix/prevent-debug-error-log-for-wellknown-reactions-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mitigates #2701 #2043
The current error message seems to be for development and does not provide a good UX for normal users, especially those who receive reaction emojis frequently.
So instead of showing error messages, this change will only output warning messages to the console for the known two emoji reaction types:
pleroma:emoji_reaction,reaction. (Other unknown notification types will keep showing the same error messages.)Elk could support the Emoji reaction notification in some form in the future. (Note: currently, masto.js does not provide these non-Mastodon notification type information / related to neet/masto.js#939)