Repository navigation
docs: add .github/reviewers.md and reference it from AGENTS.md - #272
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Copilot entry incorrectly states that bot-authored pull requests cannot be reviewed.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds repository guidance for selecting one active automated PR reviewer.
Changes:
- Adds the automated-reviewer status and request-command registry.
- Directs agents to consult that registry before opening PRs.
| File | Description |
|---|---|
AGENTS.md |
Adds the reviewer-selection instruction. |
.github/reviewers.md |
Documents reviewer availability, commands, and rules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sfmskywalker
commented
Oct 3, 2026
sfmskywalker
left a comment
sfmskywalker
left a comment
Member
Author
There was a problem hiding this comment.
Elsa 3 Code Review: REQUEST_CHANGES + HIGH @ b4ea5b7
Code Review, Round 1/4
Docs-only, and the evidence holds up. One rule contradicts the merge policy.
Blocking
- The merge gate is missing the confidence level (reviewers.md:21). It says
APPROVE @ <head sha>plus green CI. The gate is Elsa 3 Code Review APPROVE + HIGH on the exact head plus green CI, and any push voids it until it is re-confirmed on the new head. Suggested wording: "...an Elsa 3 Code ReviewAPPROVE + HIGH @ <head sha>on the PR's current head commit, plus green CI. Greptile is waived on this repository."
Non-blocking
- State the Greptile waiver (reviewers.md:10). "not live ... (once enabled here)" is accurate. Add "Not required for merge here (waived)" so that nobody waits for a Greptile score. Keep the Rules wording aligned with elsa-core and elsa-studio, which need a Greptile-required rule that does not apply here.
- Avoid unverifiable or stale-prone details (reviewers.md:9-11). "Its org installation (2026-10-03) covers selected repositories: elsa-core and elsa-studio" states the org configuration as fact, but the evidence only shows CodeRabbit activity on those two repos. "Not installed or not enabled for this repository" is accurate and won't go stale. The PR numbers and dates in Notes (ext#258/#259/#266/#267/#271, ext#123, ext#199, "Last reviews ext#194 and ext#193") belong in the PR body;
Last verifiedis enough. Line 22: "runs out of credits" will cause churn; suggest "is added, removed, or changes how it is requested". - Open thread. Copilot's thread on the earlier commit (bot-authored PRs) is answered and outdated, but still unresolved. Resolve it. The Copilot review ran on 36410a6, not the head; that is fine for an advisory review.
Verified
- Status rows match the PR activity from 2026-09-19 to 2026-10-03:
- The new AGENTS.md is minimal and its path is correct. No secrets, internal agent names or internal paths.
- CI is green on the head. Greptile does not apply (waived).
sfmskywalker
commented
Oct 3, 2026
sfmskywalker
left a comment
sfmskywalker
left a comment
Member
Author
There was a problem hiding this comment.
Elsa 3 Code Review: APPROVE + HIGH @ 47d8012
Code Review, Round 2/4
The Round 1 blocker and all non-blocking items are addressed.
Round 1 items
- Merge gate: fixed (reviewers.md:21). The file now states
APPROVE + HIGH @ <head sha>on the full head SHA plus green CI, and any push needs a re-confirm on the new head. - Greptile waiver: added (lines 10 and 17; AGENTS.md:3). This matches the policy that Greptile is waived on elsa-extensions.
- Stale or unverifiable details: removed. The CodeRabbit row now just says "Not enabled for this repository".
- Copilot thread: resolved.
Copilot is the only advisory reviewer here. "Continue without one" when it is unavailable matches the policy that Copilot is advisory while available. The rules are consistent with core and studio apart from the legitimate Greptile difference.
Non-blocking
- Line 10: the "How to request" column still says "Comment
@greptileai(once enabled here)", while line 17 says not to request Greptile. "n/a (waived)" would avoid the mixed message. - CLI version: "GitHub CLI 2.88 or later" is conservative (the edit command arrived in 2.87.0) and correct.
Verified on 47d8012
- CI is all green. Greptile doesn't apply (waived).
- No open review threads. The new AGENTS.md path is correct. No secrets, internal agent names or internal paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agents (Codex, Cursor and others) open most PRs here. The repository had no record of which automated reviewers actually work on it or how to request them, so agents guessed:
@copilot reviewcomments that do nothing, or Greptile triggers on repositories where it doesn't review. This adds that record and states the merge gate next to it, so an agent knows which reviews are required, which are advisory, and that the author never reviews its own PR.Change
.github/reviewers.md: one row per reviewer (status, how to request, stable notes) and the rules:APPROVE + HIGH @ <full 40-char head sha>plus green CI. Any push needs a re-confirm.AGENTS.md: "Before opening a PR, read.github/reviewers.mdand request exactly one live advisory reviewer from it once the PR is open. Greptile is waived on this repository."Docs only; no code or workflow changes. The table keeps only stable behaviour; the dated evidence lives below.
Evidence (PRs updated 2026-09-19 → 2026-10-03, plus org app installations)
gh pr edit 272 --add-reviewer @copilot). Earlier reviews on ext#193/#194 (2026-09-13); everyreview_requested: Copilotevent on #179/#193/#194 got a review. No quota messages.coderabbitai[bot]activity on this repo, including this PR; it is active only on elsa-core and elsa-studio.cursor[bot]comments (ext#258/#259/#266/#267, 2026-09-28) are Cursor cloud-agent replies, not Bugbot.github-code-quality[bot]on ext#222, #231, #252, #259, #267 (latest 2026-09-28). Automatic, not requestable.