Repository navigation
chore: pin Elsa / Elsa Studio 3.9.0 stable on release/3.9.0 - #278
Merged
Merged
Conversation
sfmskywalker
commented
Oct 4, 2026
sfmskywalker
left a comment
Member
Author
There was a problem hiding this comment.
Elsa 3 Code Review: APPROVE + HIGH @ 75308d9
Code Review, Round 1/4
Scope: the version change in Directory.Build.props on release/3.9.0: ElsaVersion goes from 3.9.0-preview.5757 to 3.9.0, and ElsaStudioVersion from 3.9.0-preview.1797 to 3.9.0.
Verified
- At this head, every
Elsa.*andElsa.Studio.*entry inDirectory.Packages.propsuses$(ElsaVersion)or$(ElsaStudioVersion). The only other Elsa-named entry isElsa.Platform.PackageManifest.Generator(0.0.1-preview.50). It's a separate tool with its own version, and this release doesn't need to change it. - All 44 distinct packages that use those two properties resolve on nuget.org at
3.9.0; I checked each.nuspecand none is missing. - CI is green at this head:
ubuntu-latest(4m42s),submit-nuget(1m43s), GitGuardian and the CLA check. So the build and tests pass against the released 3.9.0 packages.
Gate: APPROVE + HIGH with green CI. Greptile is waived for this repo.
No blocking or non-blocking notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump-only for the 3.9.0 ext cut, requested by RM. QA'd base tip: b597739.
ElsaVersion3.9.0-preview.5757 → 3.9.0ElsaStudioVersion3.9.0-preview.1797 → 3.9.0Those are the only Elsa / Elsa Studio pins: every Elsa.* and Elsa.Studio.* entry in
Directory.Packages.propsuses these two properties. I checked all 47 referenced packages, and each returns 200 on nuget.org at 3.9.0.