Boost 1.74 compatibility + Conan updates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT - switch to boost from new conan center index - run test package against cmake_find_package generator to ensure compatibility with conan-center
- use proper compiler version setting - use coro example in test_package to test for BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT setting - add proper component dependencies
JonasProgrammer
force-pushed
the
master
branch
from
f09ec88 to
1b7126c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR includes two changes: The first is rather small, I added
BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT(see yandex/ozo#266) to the defines of the generated CMake package helper for the time being, so consumers of the library don't have to do it on their end. Theasync/coro.cppexample fails under 1.74 without this, for example.Other than that, I updated the conan package, so it can be consumed with the
cmake_find_packagegenerator. Conan does not allow any find helper CMake files into conan-center, so in order to stay comaptible with that, the defines/dependencies usingtarget_link_librariesandtarget_compile_definitionsneed to be replicated in the conanfile. I updated the test package to check for compatibility accordingly.This should not change anything for users of the current conanfile, as the generated CMake helpers are still included in here and will work with the
conan_pathsgenerator.Cheers