fix: websocket errors not catching #1126
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues related to catching websocket errors.
To reproduce, run
bun run example/websocket.ts
with the following code (an uncaught error occurs):If you modify the the code to have an
onError
handler above the websocket it also doesn't catch.While on this topic: right now if there aren't any error handlers the error fails silently. Should there be a default
ws
error handler that closes the connection?