Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add SONAR implementation and resolve missing models #2014

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KennethEnevoldsen
Copy link
Contributor

Add ModelMeta for SONAR it also ensure that an "Unknown" number of parameters is not filtered.

Should resolve:
#1979
#1976

This seems to have been caused by the restructering of calls on the leaderboard.

This however leads to the side-effect that selecting number of parameters can't remove "Unknown". A solution is to add a selection box.

@x-tabdeveloping I still can't get the SONAR model to show. I was hoping you had an idea for this?

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

Add SONAR metadat, but without an implementation

Fixes #1981
by ensuring that "Unknown" number of parameters is not filtered.

Should resolve:
#1979
#1976

This seems to have been caused by the restructering of calls on the leaderboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant