Skip to content

Fix an issue with the --no-warp-drive option#272

Merged
NullVoxPopuli merged 1 commit into
ember-cli:mainfrom
Windvis:no-warp-drive-flag-issue
Apr 28, 2026
Merged

Fix an issue with the --no-warp-drive option#272
NullVoxPopuli merged 1 commit into
ember-cli:mainfrom
Windvis:no-warp-drive-flag-issue

Conversation

@Windvis
Copy link
Copy Markdown
Contributor

@Windvis Windvis commented Apr 28, 2026

No description provided.

@Windvis Windvis force-pushed the no-warp-drive-flag-issue branch from 1014c1a to 2185b23 Compare April 28, 2026 11:27
@Windvis Windvis changed the title Add a failing test for the --no-warp-drive flag Fix an issue with the --no-warp-drive option Apr 28, 2026
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Apr 28, 2026
Comment thread index.js Outdated
This prevents the option from being added to the `ember-cli-update.json` file if the option is not passed.
@Windvis Windvis force-pushed the no-warp-drive-flag-issue branch from 7ee117f to ab464b2 Compare April 28, 2026 11:43
@Windvis Windvis requested a review from NullVoxPopuli April 28, 2026 11:43
@NullVoxPopuli NullVoxPopuli merged commit 41b5a0e into ember-cli:main Apr 28, 2026
56 checks passed
@mansona
Copy link
Copy Markdown
Member

mansona commented Apr 28, 2026

@NullVoxPopuli before we merge things like this can we identify the first release that it was a problem in. If it was the current release (6.12) this PR should have targeted the release branch and not main and we merge forward from there

@mansona
Copy link
Copy Markdown
Member

mansona commented Apr 28, 2026

@Windvis do you happen to know what version this first started to be an issue?

@Windvis Windvis deleted the no-warp-drive-flag-issue branch April 28, 2026 14:05
@Windvis
Copy link
Copy Markdown
Contributor Author

Windvis commented Apr 28, 2026

@Windvis do you happen to know what version this first started to be an issue?

This is the commit that introduced the code I think: 412170e

So 6.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants