Code

add Modifier support#23

Code

Open

NullVoxPopuli wants to merge 6 commits intomasterember-codemods/ember-codemods-telemetry-helpers:masterfrom add-modifiers-to-default-analyzerember-codemods/ember-codemods-telemetry-helpers:add-modifiers-to-default-analyzerCopy head branch name to clipboard

+201-13

Commits

Commits on Oct 29, 2019

• add Modifier support

  NullVoxPopuli

  committed
  b7df5e6

  Copy full SHA for b7df5e6

Commits on Nov 2, 2019

• actually acquire modifiers

  NullVoxPopuli

  committed
  46f4fc6

  Copy full SHA for 46f4fc6

• const needs to be in the analyze function

  NullVoxPopuli

  committed
  cebc51f

  Copy full SHA for cebc51f

• success

  NullVoxPopuli

  committed
  39b19cd

  Copy full SHA for 39b19cd

• detecting modifiers from packages work. but if a modifier in your app happens to have an EmberObject as its ancestor, that is not detected. It seems only native classes are detected right now

  NullVoxPopuli

  committed
  e2e4da6

  Copy full SHA for e2e4da6

• it works!

  NullVoxPopuli

  committed
  7aeecc7

  Copy full SHA for 7aeecc7