Add deprecation guides for ComputedProperties #1412
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kategengler
reviewed
Aug 22, 2025
| It created a second property that reflected another property's value. | ||
|
|
||
| ## Migration | ||
| Prefer direct access to the original tracked state, or use a simple getter and setter. |
There was a problem hiding this comment.
alias could point to a computed property, a getter, or really anything so this may need to describe how make sure they work going forward.
kategengler
reviewed
Aug 22, 2025
| ``` | ||
| After: | ||
| ```js | ||
| class Cart { |
kategengler
reviewed
Aug 22, 2025
| import ComputedProperty from '@ember/object/computed'; | ||
| // rarely used directly | ||
| ``` | ||
| After: Remove the import; refactor any custom meta-programming to simple getters. |
There was a problem hiding this comment.
I think custom ComputedProperties weren't rare.
kategengler
reviewed
Aug 22, 2025
| ``` | ||
| After: | ||
| ```js | ||
| import { isEmpty } from '@ember/utils'; |
There was a problem hiding this comment.
@ember/utils has a deprecation RFC that has not landed https://github.com/emberjs/rfcs/blob/master/text/0334-deprecate-ember-utils.md?plain=1
|
RFC review notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.