fix: update GitHub Pages workflow to use Node.js 20 and pnpm 9 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Thanks for keeping this up to date 🎉 if we're updating it we should make sure that we're updating it to the best practice (which is kind of hard to see in the other github action because of the use of variables for node versions)
Also it's worth noting that this action is just deploying the lint-to-the-future dashboard on https://ember-learn.github.io/ember-api-docs/ so we don't need to wait for the full deployment to be sure that this will be ok to merge 👍
mansona
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GitHub Pages workflow to use Node.js 20 and pnpm 9, matching the local setup and CI.yaml to fix deployment failures.