Skip to content

fix: add spacing before Admin link in blog template #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 9 commits into from
Jul 17, 2026
+9 −0
Merged

fix: add spacing before Admin link in blog template #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2335b63
fix: add spacing before Admin link in blog template
Cozmocat Jul 12, 2026
23ad935
style: format admin navigation spacing
Cozmocat Jul 12, 2026
906e198
fix: sync admin nav spacing to cloudflare template
Cozmocat Jul 12, 2026
7b28b27
style: format admin navigation spacing
Cozmocat Jul 12, 2026
9d92273
fix: add admin nav spacing to cloudflare template
Cozmocat Jul 12, 2026
7571a00
fix: add admin nav spacing to cloudflare template
Cozmocat Jul 12, 2026
1667ade
style: use tabs for admin navigation spacing
Cozmocat Jul 12, 2026
f13adb6
style: use tabs for Cloudflare admin navigation spacing
Cozmocat Jul 12, 2026
731b7ef
style: use tabs for Cloudflare admin navigation spacing
Cozmocat Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions templates/blog-cloudflare/src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@

:root {
}

.nav-admin {

@emdashbot emdashbot Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] The Cloudflare variant now includes the .nav-admin spacing rule, but it's missing the explanatory comment that exists in the base blog template (templates/blog/src/styles/theme.css). Because these files are kept in sync by scripts/sync-cloudflare-templates.sh, they should be identical; running that script would add this comment and create unrelated future diff noise. Add the matching comment so both templates stay in lockstep.

Suggested change
.nav-admin {
/* Keep the signed-in Admin link separated from the primary navigation. */
.nav-admin {

margin-inline-start: var(--spacing-5);
}
5 changes: 5 additions & 0 deletions templates/blog/src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,8 @@

:root {
}

/* Keep the signed-in Admin link separated from the primary navigation. */
.nav-admin {

@emdashbot emdashbot Bot Jul 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] This fixes templates/blog, but templates/blog-cloudflare/src/styles/theme.css still has no .nav-admin spacing rule at the PR head. Since the description says the change should flow to the Cloudflare template, either run ./scripts/sync-cloudflare-templates.sh now or apply the same .nav-admin { margin-inline-start: var(--spacing-5); } addition to templates/blog-cloudflare/src/styles/theme.css so the checked-in variant isn't left with the original spacing bug.

margin-inline-start: var(--spacing-5);
}
Loading