Skip to content

revert: flue-review Workers trace collection (#2372) — reviews hang in hydrating - #2384

Merged
ascorbic merged 1 commit into
mainfrom
revert/flue-review-traces
Aug 8, 2026
Merged

revert: flue-review Workers trace collection (#2372) — reviews hang in hydrating#2384
ascorbic merged 1 commit into
mainfrom
revert/flue-review-traces

Conversation

@ascorbic

@ascorbic ascorbic commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Reverts #2372 (observability.traces.enabled on emdash-flue-review) to restore the PR review bot.

Evidence: flue-review redeployed with traces at 12:35 UTC today; every review attempted since then has hung silently in the hydrating stage until the watchdog kills it — the five bot-nextgen stack PRs on un-draft, a solo re-trigger of #2375, and its automatic stale-run retry (three attempts on one PR, all identical). No successful review has completed on the traced build; the last successes were all pre-deploy. Hydration is the reviewer's most I/O-intense phase (bulk R2/DO workspace writes), consistent with per-operation trace instrumentation as the mechanism. Live-tail transcript of the failure sequence available.

This restores the pre-#2372 config while the interaction is investigated (likely re-land shape: head_sampling_rate or a workaround for the hydration hot path). The bot being down blocks all PR review flow, so this is proposed for direct maintainer merge — the bot cannot review its own resuscitation.

Verification after merge + Workers Builds deploy: re-apply bot:review on #2375; the review should progress past Preparing PR within a few minutes.

Closes #

Type of change

  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes — n/a, config-only revert
  • pnpm lint passes — n/a, config-only
  • pnpm test passes — n/a, config-only
  • pnpm format has been run — n/a, pure revert
  • I have added/updated tests for my changes — n/a
  • User-visible strings in the admin UI are wrapped for translation — n/a
  • I have added a changeset — n/a, infra worker
  • New features link to an approved Discussion — n/a

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: Claude Fable 5 (Claude Code)

Screenshots / test output

Watchdog signature on all failed runs: The review stopped reporting progress while in the 'hydrating' stage.


Try this PR

Open a fresh playground →

A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.

Tracks revert/flue-review-traces. Updated automatically when the playground redeploys.

Copilot AI lite review requested due to automatic review settings August 8, 2026 17:19
@changeset-bot

changeset-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc0da6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts enabling Cloudflare Workers trace collection for the infra/flue-review worker by removing the observability.traces.enabled block, aiming to restore normal operation of the PR review bot (which is reportedly hanging during the hydrating stage when traces are enabled).

Changes:

  • Removes the observability.traces configuration from infra/flue-review/wrangler.jsonc.
  • Keeps observability.enabled: true intact while disabling trace collection specifically.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-do cc0da6f Aug 08 2026, 05:24 PM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-cache cc0da6f Aug 08 2026, 05:24 PM

@ascorbic
ascorbic enabled auto-merge (squash) August 8, 2026 17:24
@pkg-pr-new

pkg-pr-new Bot commented Aug 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2384

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2384

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2384

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2384

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2384

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2384

emdash

npm i https://pkg.pr.new/emdash@2384

create-emdash

npm i https://pkg.pr.new/create-emdash@2384

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2384

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2384

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2384

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2384

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2384

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2384

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2384

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2384

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2384

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2384

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2384

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2384

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2384

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2384

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2384

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2384

commit: cc0da6f

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-playground cc0da6f Aug 08 2026, 05:24 PM

@ascorbic
ascorbic merged commit 582e89d into main Aug 8, 2026
47 of 48 checks passed
@ascorbic
ascorbic deleted the revert/flue-review-traces branch August 8, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: signed review/needs-review No maintainer or bot review yet size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants