revert: flue-review Workers trace collection (#2372) — reviews hang in hydrating - #2384
Conversation
This reverts commit 3540e33.
|
There was a problem hiding this comment.
Pull request overview
Reverts enabling Cloudflare Workers trace collection for the infra/flue-review worker by removing the observability.traces.enabled block, aiming to restore normal operation of the PR review bot (which is reportedly hanging during the hydrating stage when traces are enabled).
Changes:
- Removes the
observability.tracesconfiguration frominfra/flue-review/wrangler.jsonc. - Keeps
observability.enabled: trueintact while disabling trace collection specifically.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-do | cc0da6f | Aug 08 2026, 05:24 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | cc0da6f | Aug 08 2026, 05:24 PM |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | cc0da6f | Aug 08 2026, 05:24 PM |
What does this PR do?
Reverts #2372 (
observability.traces.enabledonemdash-flue-review) to restore the PR review bot.Evidence: flue-review redeployed with traces at 12:35 UTC today; every review attempted since then has hung silently in the
hydratingstage until the watchdog kills it — the five bot-nextgen stack PRs on un-draft, a solo re-trigger of #2375, and its automatic stale-run retry (three attempts on one PR, all identical). No successful review has completed on the traced build; the last successes were all pre-deploy. Hydration is the reviewer's most I/O-intense phase (bulk R2/DO workspace writes), consistent with per-operation trace instrumentation as the mechanism. Live-tail transcript of the failure sequence available.This restores the pre-#2372 config while the interaction is investigated (likely re-land shape:
head_sampling_rateor a workaround for the hydration hot path). The bot being down blocks all PR review flow, so this is proposed for direct maintainer merge — the bot cannot review its own resuscitation.Verification after merge + Workers Builds deploy: re-apply
bot:reviewon #2375; the review should progress pastPreparing PRwithin a few minutes.Closes #
Type of change
Checklist
pnpm typecheckpasses — n/a, config-only revertpnpm lintpasses — n/a, config-onlypnpm testpasses — n/a, config-onlypnpm formathas been run — n/a, pure revertAI-generated code disclosure
Screenshots / test output
Watchdog signature on all failed runs:
The review stopped reporting progress while in the 'hydrating' stage.Try this PR
Open a fresh playground →
A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.
Tracks
revert/flue-review-traces. Updated automatically when the playground redeploys.