fix(admin): stabilize editor sidebar layout - #2468
Conversation
🦋 Changeset detectedLatest commit: 2552ba0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 2552ba0 | Aug 16 2026, 05:12 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 2552ba0 | Aug 16 2026, 05:11 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-do | 2552ba0 | Aug 16 2026, 05:11 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 2552ba0 | Aug 16 2026, 05:13 PM |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
There was a problem hiding this comment.
This PR fixes two tightly-scoped admin UI layout bugs: drag-handle vertical alignment for collapsible vs. standard sidebar sections, and a meta-description textarea remount/shift caused by Kumo's conditional field description. Both changes are the right shape for the problem, stay inside the admin package, and are accompanied by tests (unit remount test + E2E alignment assertions). I checked i18n wrapping, Tailwind logical properties, changeset hygiene, and scope discipline; the diff is clean on all of those.
I have one non-blocking suggestion: the three new changesets introduce two nearly identical alignment bullets for the same @emdash-cms/admin patch release. Per AGENTS.md, changesets are user-facing release notes and "one sentence is often enough"; consolidating the two alignment changesets into one would make the release notes clearer. The SEO counter changeset should remain separate.
I did not run the test suite or linter (static review only); I took the PR's test/lint/typecheck claims as unverified context and found no static reason to doubt them.
| "@emdash-cms/admin": patch | ||
| --- | ||
|
|
||
| Fixes misaligned drag handles beside standard editor sidebar section headings. |
There was a problem hiding this comment.
[suggestion] This changeset and .changeset/align-editor-sidebar-handles.md describe the same user-facing alignment fix for @emdash-cms/admin and will appear as two nearly identical bullets in the same patch release notes. AGENTS.md treats changesets as release notes users read and says "one sentence is often enough." Consider consolidating them into a single changeset (e.g. Fixes vertical alignment of editor sidebar drag handles with both standard and collapsible section headings.) and keeping stabilize-seo-description-layout.md separate.
e06c6c1 to
fe951e8
Compare
What does this PR do?
Fixes vertical alignment throughout the content editor sidebar. Drag handles now share a centerline with both standard section headings and collapsible Outline/Revisions headers.
Also prevents the Meta Description textarea from shifting and remounting after its first character by keeping the character counter outside Kumo's conditional field wrapper.
Related issue: none.
Type of change
Checklist
pnpm typecheckpasses — currently fails in unchangedorigin/maincode atpackages/core/src/database/repositories/content.ts:1625becauseContentRepository.restampEntryPivotdoes not existpnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
pnpm lint: passed with zero diagnosticsSeoPanelandSortableContentSettingsSections)/_emdash/api/setup/dev-bypass?token=1returns the existingDEV_BYPASS_ERRORpnpm typecheckreaches the unchangedorigin/mainfailure documented above; admin package typechecking passesTry this PR
Open a fresh playground →
A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.
Tracks
fix/editor-right-sidebar. Updated automatically when the playground redeploys.