Skip to content

fix(admin): stabilize editor sidebar layout - #2468

Open
khoinguyenpham04 wants to merge 4 commits into
mainfrom
fix/editor-right-sidebar
Open

fix(admin): stabilize editor sidebar layout#2468
khoinguyenpham04 wants to merge 4 commits into
mainfrom
fix/editor-right-sidebar

Conversation

@khoinguyenpham04

@khoinguyenpham04 khoinguyenpham04 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes vertical alignment throughout the content editor sidebar. Drag handles now share a centerline with both standard section headings and collapsible Outline/Revisions headers.

Also prevents the Meta Description textarea from shifting and remounting after its first character by keeping the character counter outside Kumo's conditional field wrapper.

Related issue: none.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes — currently fails in unchanged origin/main code at packages/core/src/database/repositories/content.ts:1625 because ContentRepository.restampEntryPivot does not exist
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: N/A — this is a bug fix

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: OpenAI Codex (GPT-5) with a GPT-5.6 Terra second-opinion review

Screenshots / test output

  • pnpm lint: passed with zero diagnostics
  • Targeted admin browser tests: 17/17 passed (SeoPanel and SortableContentSettingsSections)
  • Live browser verification: Publish, Ownership, Bylines, Taxonomies, SEO, Outline, and Revisions all measured a 0px handle/title centerline delta in LTR and RTL
  • Meta Description live verification: the empty and typed states retained the same Y position, 8px label gap, and DOM node
  • Alignment E2E tests are included, but local Playwright setup fails before test execution because /_emdash/api/setup/dev-bypass?token=1 returns the existing DEV_BYPASS_ERROR
  • pnpm typecheck reaches the unchanged origin/main failure documented above; admin package typechecking passes

Try this PR

Open a fresh playground →

A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.

Tracks fix/editor-right-sidebar. Updated automatically when the playground redeploys.

@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2552ba0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/plugin-mcp-smoke Patch
@emdash-cms/fixture-perf-site Patch
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
@emdash-cms/do-demo-site Patch
@emdash-cms/do-solo-demo-site Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added area/admin size/M review/needs-review No maintainer or bot review yet labels Aug 14, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-playground 2552ba0 Aug 16 2026, 05:12 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-cache 2552ba0 Aug 16 2026, 05:11 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-do 2552ba0 Aug 16 2026, 05:11 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
docs 2552ba0 Aug 16 2026, 05:13 PM

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2468

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2468

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2468

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2468

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2468

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2468

emdash

npm i https://pkg.pr.new/emdash@2468

create-emdash

npm i https://pkg.pr.new/create-emdash@2468

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2468

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2468

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2468

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2468

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2468

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2468

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2468

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2468

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2468

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2468

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2468

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2468

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2468

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2468

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2468

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2468

commit: 2552ba0

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes two tightly-scoped admin UI layout bugs: drag-handle vertical alignment for collapsible vs. standard sidebar sections, and a meta-description textarea remount/shift caused by Kumo's conditional field description. Both changes are the right shape for the problem, stay inside the admin package, and are accompanied by tests (unit remount test + E2E alignment assertions). I checked i18n wrapping, Tailwind logical properties, changeset hygiene, and scope discipline; the diff is clean on all of those.

I have one non-blocking suggestion: the three new changesets introduce two nearly identical alignment bullets for the same @emdash-cms/admin patch release. Per AGENTS.md, changesets are user-facing release notes and "one sentence is often enough"; consolidating the two alignment changesets into one would make the release notes clearer. The SEO counter changeset should remain separate.

I did not run the test suite or linter (static review only); I took the PR's test/lint/typecheck claims as unverified context and found no static reason to doubt them.

"@emdash-cms/admin": patch
---

Fixes misaligned drag handles beside standard editor sidebar section headings.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] This changeset and .changeset/align-editor-sidebar-handles.md describe the same user-facing alignment fix for @emdash-cms/admin and will appear as two nearly identical bullets in the same patch release notes. AGENTS.md treats changesets as release notes users read and says "one sentence is often enough." Consider consolidating them into a single changeset (e.g. Fixes vertical alignment of editor sidebar drag handles with both standard and collapsible section headings.) and keeping stabilize-seo-description-layout.md separate.

@github-actions github-actions Bot added review/awaiting-author Reviewed; waiting on the author to respond review/needs-rereview Author pushed changes since the last review and removed review/needs-review No maintainer or bot review yet review/awaiting-author Reviewed; waiting on the author to respond labels Aug 14, 2026
@khoinguyenpham04
khoinguyenpham04 force-pushed the fix/editor-right-sidebar branch from e06c6c1 to fe951e8 Compare August 16, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin review/needs-rereview Author pushed changes since the last review size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant