fix(admin): make all taxonomy tag matches reachable - #2495
fix(admin): make all taxonomy tag matches reachable#2495khoinguyenpham04 wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: 48981c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-do | 48981c7 | Aug 16 2026, 02:26 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 48981c7 | Aug 16 2026, 02:24 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 48981c7 | Aug 16 2026, 02:24 PM |
There was a problem hiding this comment.
This PR addresses #2477 by replacing the hard-coded five-suggestion tag picker with a Kumo Combobox multi-select. The approach is sound: it keeps locale scoping via withLocale, performs client-side filtering with the existing diacritic-aware termMatches/termExactMatches, promotes exact matches to the top of the list, serializes rapid saves with a useMutation scope, and preserves creation input/API errors. The test additions are behavior-oriented and cover reachability, exact-match ordering, pointer/keyboard selection, rapid-save serialization, error recovery, and optimistic creation.
I read the diff, the full changed component/test files, and checked against AGENTS.md (localization, RTL-safe Tailwind, Kumo usage, changeset, comment discipline, query-count policy). The implementation looks correct and the changeset is user-facing. The only issues are two comments that restate what the surrounding code already plainly does, violating the AGENTS comment discipline.
Scope checkThis PR changes 550 lines across 3 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
ee5f416 to
48981c7
Compare
|
I'm guessing you didn't notice #2491! |
I did this yesterday! But didn't push until today LOL |
What does this PR do?
Replaces the custom five-result taxonomy tag input with a Kumo multi-select combobox.
Closes #2477
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.Discussion: N/A — this is a bug fix.
AI-generated code disclosure
Screenshots / test output