Skip to content

i18n(fr): replace byline translation - #2540

Open
ArmandPhilippot wants to merge 3 commits into
emdash-cms:mainfrom
ArmandPhilippot:i18n/fr-replace-byline-translation
Open

i18n(fr): replace byline translation#2540
ArmandPhilippot wants to merge 3 commits into
emdash-cms:mainfrom
ArmandPhilippot:i18n/fr-replace-byline-translation

Conversation

@ArmandPhilippot

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the French translation for "byline" and "ownership".

In French, the most natural way to translate "byline" was "auteur" (e.g. "guest byline" would be translated with "auteur invité", this is a concept already used elsewhere). But, in EmDash, we also have the concept of "author" and this ends up clashing. The literal translation of "byline" would be "signature" but, in French, "signature invitée" doesn't sound natural/is not something we would use.

I think a reasonable translation for byline would be "collaborateur", and it would make sense for

{t`Also match the byline linked to an entry's author when it has none assigned.`}

The translation would be:

Fait également correspondre le collaborateur associé à l'auteur de l'entrée, lorsqu'aucun collaborateur n'est attribué.

I also updated the translation for "ownership". By default, the select field shows "Non attribué". As the label (Authors) is not visible, this is a bit confusing what "Propriété" is (this word can have different meaning). I think "Responsabilité" would be a better translation here.

Follow-up on #2464

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change) (MarketplacePluginDetail > displays install count is still failing locally for me, but unrelated to my changes)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool:

Screenshots / test output

When updating a post:

Before After
Sidebar Shows the 'Propriété', 'Auteurs', and 'Taxonomies' section in the French sidebar before the changes Shows the 'Propriété', 'Collaborateurs', and 'Taxonomies' section in the French sidebar after the changes
Accessibility tree Shows the accessibility tree in French before the changes: Propriété > Auteurs > Non attribué Shows the accessibility tree in French after the changes: Responsabilité > Auteurs > Non attribué

Copilot AI lite review requested due to automatic review settings August 18, 2026 12:05
@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9c92a5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/fr/messages.po Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the French (fr) admin UI translations to avoid a terminology clash between EmDash’s “byline” concept and the existing “author” concept, and to make the “Ownership” label clearer in context.

Changes:

  • Replaces French translations of “byline”/“bylines” from “auteur(s)” to “collaborateur(s)” across related UI strings.
  • Updates the French translation of “Ownership” from “Propriété” to “Responsabilité”.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2540

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2540

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2540

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2540

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2540

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2540

emdash

npm i https://pkg.pr.new/emdash@2540

create-emdash

npm i https://pkg.pr.new/create-emdash@2540

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2540

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2540

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2540

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2540

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2540

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2540

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2540

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2540

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2540

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2540

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2540

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2540

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2540

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2540

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2540

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2540

commit: 9c92a5a

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a focused translation PR that addresses the real ambiguity in French between "auteur" (author) and the EmDash "byline" concept, plus an ownership label that was unclear without its surrounding heading. The approach is sound and matches the rationale in the description.

I read the diff and the full French catalog, then searched for any remaining "auteur" translations that might now collide with "collaborateur". The byline-related msgids are all updated consistently to "collaborateur" and the phrase for the inferred-byline toggle correctly maps "byline" -> "collaborateur" and "author" -> "auteur". The "Ownership" -> "Responsabilité" change is a sensible label-only improvement in the sidebar.

No code is changed, so the normal bag of concerns — SQL, auth, API shape, Tailwind RTL, locale filters, query counts — does not apply. There are no tests asserting exact French strings that would need updating.

The only remaining issue is procedural: @emdash-cms/admin is a published package, so AGENTS.md/CONTRIBUTING.md require a changeset whenever a published package changes behavior. Translation of user-visible strings counts as such a change, and the author left the changeset checklist item unchecked. Add a changeset so the updated French catalog actually ships with the next release.


Findings

  • [needs fixing] packages/admin/package.json:2

    AGENTS.md § Workflow and CONTRIBUTING.md § Changesets require a changeset whenever a published package changes behavior. @emdash-cms/admin is a published package (no "private": true, has prepublishOnly, and is in .changeset/config.json's fixed release group), and this PR updates its French user-visible strings. Without a changeset the updated translations may not be released.

    Add a .changeset/*.md file, for example:

    ---
    "@emdash-cms/admin": patch
    ---
    
    Updates the French byline and ownership translations so byline strings consistently use "collaborateur" and the ownership section is labeled "Responsabilité".
    

@ArmandPhilippot

Copy link
Copy Markdown
Contributor Author

There is no changeset because of Matt's answer to my question in #1809 (review) (and #2400 or #2464 have been merged without any changeset).

@github-actions github-actions Bot added review/awaiting-author Reviewed; waiting on the author to respond and removed review/needs-review No maintainer or bot review yet labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin review/awaiting-author Reviewed; waiting on the author to respond size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants