i18n(fr): replace byline translation - #2540
Conversation
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Pull request overview
This PR updates the French (fr) admin UI translations to avoid a terminology clash between EmDash’s “byline” concept and the existing “author” concept, and to make the “Ownership” label clearer in context.
Changes:
- Replaces French translations of “byline”/“bylines” from “auteur(s)” to “collaborateur(s)” across related UI strings.
- Updates the French translation of “Ownership” from “Propriété” to “Responsabilité”.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
There was a problem hiding this comment.
This is a focused translation PR that addresses the real ambiguity in French between "auteur" (author) and the EmDash "byline" concept, plus an ownership label that was unclear without its surrounding heading. The approach is sound and matches the rationale in the description.
I read the diff and the full French catalog, then searched for any remaining "auteur" translations that might now collide with "collaborateur". The byline-related msgids are all updated consistently to "collaborateur" and the phrase for the inferred-byline toggle correctly maps "byline" -> "collaborateur" and "author" -> "auteur". The "Ownership" -> "Responsabilité" change is a sensible label-only improvement in the sidebar.
No code is changed, so the normal bag of concerns — SQL, auth, API shape, Tailwind RTL, locale filters, query counts — does not apply. There are no tests asserting exact French strings that would need updating.
The only remaining issue is procedural: @emdash-cms/admin is a published package, so AGENTS.md/CONTRIBUTING.md require a changeset whenever a published package changes behavior. Translation of user-visible strings counts as such a change, and the author left the changeset checklist item unchecked. Add a changeset so the updated French catalog actually ships with the next release.
Findings
-
[needs fixing]
packages/admin/package.json:2AGENTS.md § Workflow and CONTRIBUTING.md § Changesets require a changeset whenever a published package changes behavior.
@emdash-cms/adminis a published package (no"private": true, hasprepublishOnly, and is in.changeset/config.json's fixed release group), and this PR updates its French user-visible strings. Without a changeset the updated translations may not be released.Add a
.changeset/*.mdfile, for example:--- "@emdash-cms/admin": patch --- Updates the French byline and ownership translations so byline strings consistently use "collaborateur" and the ownership section is labeled "Responsabilité".
|
There is no changeset because of Matt's answer to my question in #1809 (review) (and #2400 or #2464 have been merged without any changeset). |
What does this PR do?
Updates the French translation for "byline" and "ownership".
In French, the most natural way to translate "byline" was "auteur" (e.g. "guest byline" would be translated with "auteur invité", this is a concept already used elsewhere). But, in EmDash, we also have the concept of "author" and this ends up clashing. The literal translation of "byline" would be "signature" but, in French, "signature invitée" doesn't sound natural/is not something we would use.
I think a reasonable translation for byline would be "collaborateur", and it would make sense for
emdash/packages/admin/src/components/BylineFilter.tsx
Line 175 in 6602ae0
The translation would be:
I also updated the translation for "ownership". By default, the select field shows "Non attribué". As the label (Authors) is not visible, this is a bit confusing what "Propriété" is (this word can have different meaning). I think "Responsabilité" would be a better translation here.
Follow-up on #2464
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change) (MarketplacePluginDetail > displays install countis still failing locally for me, but unrelated to my changes)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
When updating a post: