Add Slider::snap_values to snap slider to user-specified values
#2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac-freeman
changed the title
emilk
requested changes
Jan 23, 2023
There was a problem hiding this comment.
Good start, but I actually think smart-aim and snap-values are orthogonal. That is: I see no reason why you shouldn't be able to turn either feature on/off independently.
If smart-aim is enabled, perform that. If there are snap-values, snap to the closest one (if within aim_radius). Done!
emilk
reviewed
Jan 24, 2023
Snap aim slider
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
requested changes
Feb 4, 2023
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
ac-freeman
commented
Feb 9, 2023
| // Divide aim_radius by the granularity we want | ||
| if self.snap_values_only || closest_distance < ui.input().aim_radius() as f64 / 15.0 { | ||
| // Multiply aim_radius by the granularity we want | ||
| if self.snap_values_only || closest_distance < ui.input(|i| i.aim_radius()) * 5.0 { |
There was a problem hiding this comment.
I think some kind of multiplier is necessary here, but I'm not sure how we should determine what it is.
With no multiplier, the aim radius is too small for it to actually snap. The precision is too tight for using a mouse.
By multiplying the aim radius by 5 as I have here, the snap works more like I expect.
emilk
reviewed
Mar 29, 2023
emilk
changed the title
Slider::snap_values to snap slider to user-specified values
emilk
reviewed
Mar 25, 2024
| @@ -5,7 +5,7 @@ NOTE: [`epaint`](crates/epaint/CHANGELOG.md), [`eframe`](crates/eframe/CHANGELOG | |||
|
|
|||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Add `Slider::snap_values`, which lets the user define certain points to snap the slider to when clicking or dragging ([#2523](https://github.com/emilk/egui/pull/2523)). | |||
There was a problem hiding this comment.
Suggested change
| * Add `Slider::snap_values`, which lets the user define certain points to snap the slider to when clicking or dragging ([#2523](https://github.com/emilk/egui/pull/2523)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to set "snap" points with
Slider::smart_aim_values. When the slider marker is within a user-specified range of one of these points, it will jump to that point. Ifsmart_aimis disabled, then these values don't do anything. Ifsmart_aimis enabled, then regular smart aim is used as normal whenever the marker is outside the user-specified range of these snap points.I added it to the demo app for seeing how it works. I'm open to feedback to make sure it fits in with the structural and stylistic requirements of the project.