Skip to content

Fix some bug regarding to 7bit mode #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hieucdtspk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some bug regarding to 7bit mode #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pdu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,10 @@ pduParser.decode7Bit = function(code, count) {
}

var ascii = '';
for(i in bin)
for(i in bin){
if (parseInt(bin[i], 2) == 0) break; // terminate ascii string on null chanracter!
ascii += String.fromCharCode(parseInt(bin[i], 2));
}

return ascii;
}
Expand Down Expand Up @@ -290,7 +292,10 @@ pduParser.generate = function(message) {

} else if(message.encoding === '7bit') {
user_data = pduParser.encode7Bit(text);
var size = user_data.length / 2;
// var size = user_data.length / 2;
var size = text.length; // the actual len
// console.log("sms.text %d: %s", text.length, text);
// console.log("sms.user_data %d: %s", user_data.length, user_data);
}

pdus[i] += ('00'+parseInt(size).toString(16)).slice(-2);
Expand Down