Use FFI::MemoryPointer from_string for Ssdeep.from_string#1
Open
pachoo wants to merge 1 commit intoemonti:masterfrom
Open
Use FFI::MemoryPointer from_string for Ssdeep.from_string#1pachoo wants to merge 1 commit intoemonti:masterfrom
pachoo wants to merge 1 commit intoemonti:masterfrom
Conversation
Previously this code was using the string's size in characters NOT its size in bytes to determine how many bytes to copy into buf. By using the FFI::MemoryPointer.from_string method this takes care of string encoding so that all of the string's bytes are copied.
Owner
|
Looks like this is actually what you want here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this code was using the string's size in characters NOT its size in bytes to determine how many bytes to copy into buf. By using the FFI::MemoryPointer.from_string method this takes care of string encoding so that all of the string's bytes are copied.