fix: start schema_version at 0 so migrations begin from version 1#18
Merged
johnny-emp merged 2 commits intomainfrom Feb 5, 2026
Merged
fix: start schema_version at 0 so migrations begin from version 1#18johnny-emp merged 2 commits intomainfrom
johnny-emp merged 2 commits intomainfrom
Conversation
Previously, schema_version was initialized to 1, which meant that migrations starting from version 1 would be skipped (since the filter uses `version > current_version`). This forced users to start their migrations from version 2, which was confusing and undocumented. This change: - Initializes schema_version to 0 in SQLite, LMDB, and core meta types - Updates the generate function to start at version 1 for new migrations - Updates documentation and examples to reflect version 1 as the first - Updates rollback error message to reflect version 0 as initial state - Updates all tests to use version 1 as the first migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_versionwas previously initialized to 1, but the filter usesversion > current_version, so version 1 migrations never ranChanges
schema_versionto 0 in SQLite, LMDB, and core meta typesgeneratefunction to start at version 1 for new migrationsTest plan