Enable createWasm to use async/await with closure and babel #23704
+15
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
async_createWasm
branch
from
3d8d5d1 to
e3f079f
Compare
|
FWIW, I once successfully implemented a better solution for this, but it turned out to be a large change, see: |
I also implemented another approach in #23261 which actually fixes #23158, but sadly it causes code size regressions, because closure doesn't seem to be able to reason about code inside of functions the same way it can about top level code. |
sbc100
force-pushed
the
async_createWasm
branch
from
e3f079f to
11f1385
Compare
sbc100
changed the title
kleisauke
reviewed
Feb 19, 2025
sbc100
force-pushed
the
async_createWasm
branch
2 times, most recently
from
f23ca44 to
821b11c
Compare
I really which we had a better solution here, but this makes the use of async/await independent of closure usage. This is a workaround for emscripten-core#23158, but it also happens to fix emscripten-core#23687 which stems from the same issue. Fixes: emscripten-core#23687
sbc100
force-pushed
the
async_createWasm
branch
from
821b11c to
547dcc7
Compare
brendandahl
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really which we had a better solution here, but this makes the use of async/await independent of closure usage.
This is a workaround for #23158, but it also happens to fix #23687
which stems from the same issue.
Fixes: #23687