Add typings for explicit resource management #24196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
approved these changes
Apr 28, 2025
This is a follow-up to emscripten-core#23818. When targeting any existing ES version, TypeScript transpiles `using ...` and doesn't require any typings. However, when targeting ESNext, it expects `using ...` to be a native feature, and then looks up `[Symbol.dispose]` in the type and fails with a type validation error if it doesn't exist. Since there's no way to do conditional compilation based on target version in TS, I'm adding this property to type declarations but marking with `ts-ignore` so that `Symbol.dispose` not existing is not an error in versions below ESNext.
RReverser
force-pushed
the
symbol-dispose-typings
branch
from
96f03f7 to
2e7524c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #23818.
When targeting an existing ES version like ES2024, TypeScript transpiles
using ...and doesn't require any typings.However, when targeting ESNext, it expects
using ...to be a native feature, and then looks up[Symbol.dispose]in the type and fails with a type validation error if it doesn't exist.Since there's no way to do conditional compilation based on target version in TS, I'm adding this property to type declarations but marking with
ts-ignoreso thatSymbol.disposenot existing is not an error in versions below ESNext.