Speed up SSE4.1 test by splitting individual unrolled blocks into their own functions. #24401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
May 23, 2025
| @@ -547,9 +550,10 @@ __m128 ExtractIntInRandomOrder(unsigned int *arr, int i, int n, int prime) { | |||
| char str[256]; tostr(&m1, str); \ | |||
| char str2[256]; tostr(&ret, str2); \ | |||
| printf("%s(%s, 0x%08X, %d) = %s\n", #func, str, interesting_ints[j], Tint, str2); \ | |||
| } | |||
| } \ | |||
| }(); | |||
There was a problem hiding this comment.
Can we use simple C functions instead of C++ lambda's perhaps? That would also help with debug-ability as it would yield meaningful backtraces. If its not easy then this change is still better of course. lgtm either way.
There was a problem hiding this comment.
I don't know how to do that easily. The function bodies would then need to be emitted somewhere else by one set of macro expansion magic, and then calls to those functions separately in another place.
juj
force-pushed
the
further_optimize_sse4_1_test_suite
branch
from
2be37fa to
d375a38
Compare
…ir own functions.
juj
force-pushed
the
further_optimize_sse4_1_test_suite
branch
from
d375a38 to
0524c96
Compare
|
Ping - is this ok to land? |
sbc100
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: