[llvm-libc] Import the already imported part of llvm-libc from llvm main #24604
Conversation
system/lib/update_llvm_libc.py
Outdated
| script_dir = os.path.abspath(os.path.dirname(__file__)) | ||
| emscripten_root = os.path.dirname(os.path.dirname(script_dir)) | ||
| default_llvm_dir = os.path.join(os.path.dirname(emscripten_root), 'llvm-project') | ||
| emscripten_patches = os.path.join(script_dir, "llvm-libc", "patches", "*.patch") |
There was a problem hiding this comment.
We don't tend to check in patches like this, at least not for the other libraries here. Instead we push our changes out to https://github.com/emscripten-core/llvm-project and maintain the patches in git.
I'm not totally opposed to this approach here, but it would be new thing for us.
There was a problem hiding this comment.
I suppose those patches are not submitted to the upstream?
If I understand correctly, you want me to submit the content of this patch to emscripten's fork of llvm?
Done.
Tests are failing due to some differences in the expected code size. Can you give me a pointer on how those are updated? |
google-yfyang
force-pushed
the
main
branch
2 times, most recently
from
b992815 to
507f145
Compare
sbc100
changed the title
Importing llvm-libc from main instead of llvm-20.
Add some basic file filtering and patch applying logic in the import script
system/lib/update_llvm_libc.py.Tested:
The same number of tests failing at HEAD when running
./test/runner llvmlibc.#24493