Fix HTML5 battery API #24677
Merged
Fix HTML5 battery API #24677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively I guess we should simply remove/deprecate this API since firefox removed it? |
The old `navigator.battery` API is not longer present in modern browsers which all use `navigator.getBattery()`. Tested locally on my laptop.
kripken
reviewed
Jul 9, 2025
| batteryManager = b; | ||
| }); | ||
| return {{{ cDefs.EMSCRIPTEN_RESULT_NO_DATA }}}; | ||
| } |
There was a problem hiding this comment.
It looks like this API fails until the async part happens - that makes me wonder how useful this API is? Do you know of users?
There was a problem hiding this comment.
This is also true for the emscripten_get_mouse_status API, so there is precedent, and that is what the EMSCRIPTEN_RESULT_NO_DATA result code is for I believe.
kripken
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
navigator.batteryAPI is not longer present in modern browsers which all usenavigator.getBattery().Tested locally on my laptop.
See https://developer.mozilla.org/en-US/docs/Web/API/BatteryManager