[file-packager] Drop support for --embed with JS output #25049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object file output is more efficient way of embedding and has been recommended via a warning since emscripten-core#16050 (early 2022). With this simplification the file packager now has essentially two output modes: 1. Preloading via JS 2. Embedding via and object file
kripken
approved these changes
Aug 25, 2025
| diagnostics.warn('support for using --preload and --embed in the same command is scheduled ' | ||
| 'for deprecation. If you need this feature please comment at ' | ||
| 'https://github.com/emscripten-core/emscripten/issues/24803') | ||
| diagnostics.error('--preload and --embed now now mutually exclusive (See https://github.com/emscripten-core/emscripten/issues/24803') |
There was a problem hiding this comment.
Suggested change
| diagnostics.error('--preload and --embed now now mutually exclusive (See https://github.com/emscripten-core/emscripten/issues/24803') | |
| diagnostics.error('--preload and --embed are mutually exclusive (See https://github.com/emscripten-core/emscripten/issues/24803') |
There was a problem hiding this comment.
(even a single "now" seems unneeded to me - we can just state the current rules, not a change in them)
| diagnostics.error('--preload and --embed now now mutually exclusive (See https://github.com/emscripten-core/emscripten/issues/24803') | ||
|
|
||
| if options.has_embedded and not options.obj_output: | ||
| diagnostics.error('--obj-output is now required when using --embed. This outputs an object file for linking directly into your application is more efficient than the old JS encoding') |
There was a problem hiding this comment.
Suggested change
| diagnostics.error('--obj-output is now required when using --embed. This outputs an object file for linking directly into your application is more efficient than the old JS encoding') | |
| diagnostics.error('--obj-output is required when using --embed. This outputs an object file for linking directly into your application which is more efficient than the old JS encoding') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object file output is more efficient way of embedding and has been recommended via a warning since #16050 (early 2022).
With this simplification the file packager now has essentially two output modes: