Skip to content

Move the removal of flaky tests from previous run to also take place in singlethreaded runs. #25269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move the removal of flaky tests from previous run to also take place in singlethreaded runs. #25269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/parallel_testsuite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ def run(self, result):
# issues.
# multiprocessing.set_start_method('spawn')

# Remove any old stale list of flaky tests before starting the run
utils.delete_file(common.flaky_tests_log_filename)

# If we are running with --failing-and-slow-first, then the test list has been
# pre-sorted based on previous test run results. Otherwise run the tests in
# reverse alphabetical order.
Expand Down
3 changes: 3 additions & 0 deletions test/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,9 @@ def set_env(name, option_value):

check_js_engines()

# Remove any old test files before starting the run
utils.delete_file(common.flaky_tests_log_filename)

def prepend_default(arg):
if arg.startswith('test_'):
return default_core_test_mode + '.' + arg
Expand Down