Skip to content

Fix parallel_testsuite in the case that tests are retried #25748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

Fix parallel_testsuite in the case that tests are retried #25748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/parallel_testsuite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ def printResult(res):
# working directory is not within it.
os.chdir(olddir)
common.force_delete_dir(temp_dir)

# Since we are returning this result to the main thread we need to make sure
# that it is serializable/picklable. To do this, we delete any non-picklable
# fields from the instance.
del result._original_stdout
del result._original_stderr

return result


Expand Down Expand Up @@ -333,11 +340,6 @@ def stopTest(self, test):
# TODO(sbc): figure out a way to display this duration information again when
# these results get passed back to the TextTestRunner/TextTestResult.
self.buffered_result.duration = self.test_duration
# Once we are done running the test and any stdout/stderr buffering has
# being taking care or, we delete these fields which the parent class uses.
# This is because they are not picklable (serializable).
del self._original_stdout
del self._original_stderr

def addSuccess(self, test):
super().addSuccess(test)
Expand Down