Fix tools/emcoverage.py - #27869
Merged
Merged
Fix tools/emcoverage.py #27869
tools/emcoverage.py #27869Conversation
sbc100
changed the title
tools/emcoverage.py and EMSDK_PYTHON normalizationtools/emcoverage.py
kripken
reviewed
Oct 5, 2026
| # Python interpreter as the parent. | ||
| if os.environ.get('EMSDK_PYTHON'): | ||
| os.environ['EMSDK_PYTHON'] = sys.executable | ||
| os.environ['EMSDK_PYTHON'] = os.path.abspath(os.environ['EMSDK_PYTHON']) |
Member
There was a problem hiding this comment.
Comment looks stale. Please explain why we need to abspath here.
Collaborator
Author
There was a problem hiding this comment.
The comment is still mostly correct. I updated it to be more clear. Does it make sense now?
Resolve the minimal set of issues that prevented `tools/emcoverage.py` from collecting coverage: 1. In `tools/emcoverage.py`, strip `-E` passed by compiler entry point scripts, and resolve commands to root `.py` files. 2. In `tools/config.py`, normalize `EMSDK_PYTHON` with `os.path.abspath()` instead of `sys.executable`, which prevented child processes from executing under custom wrappers. 3. In `tools/emcoverage.py`, pass `ignore_errors=True` to `rmtree` during reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/emcoverage.py, strip-Epassed by compiler entry point scripts, and resolve commands to root.pyfiles.tools/config.py, normalizeEMSDK_PYTHONwithos.path.abspath()instead ofsys.executable, which prevented child processes from executing under custom wrappers.tools/emcoverage.py, passignore_errors=Truetormtreeduring reset.