Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raising on nullable fields part of UniqueConstraint #9531

Merged
merged 5 commits into from
Dec 14, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test to reproduce problem with nullable fields part of a unique c…
…onstraint

Ref #9378
browniebroke committed Sep 11, 2024
commit 335a27f0fd7ef4a3e82be17b106c6358a361e57c
29 changes: 29 additions & 0 deletions tests/test_model_serializer.py
Original file line number Diff line number Diff line change
@@ -1400,3 +1400,32 @@ class Meta:
serializer.save()

self.assertEqual(instance.char_field, 'value changed by signal')


class Tag(models.Model):
name = models.CharField(max_length=100)


class UniqueConstraintModel(models.Model):
title = models.CharField(max_length=100)
age = models.IntegerField(null=True)
tag = models.ForeignKey(Tag, on_delete=models.CASCADE, related_name='instances', null=True)

class Meta:
constraints = [
# Unique constraint on 2 nullable fields
models.UniqueConstraint(name='unique_constraint', fields=('age', 'tag'))
]


class TestUniqueConstraintWithNullableFields(TestCase):
def test_nullable_unique_constraint_fields_are_not_required(self):
class UniqueConstraintSerializer(serializers.ModelSerializer):
class Meta:
model = UniqueConstraintModel
fields = '__all__'

serializer = UniqueConstraintSerializer(data={'title': 'Bob'})
self.assertTrue(serializer.is_valid(), serializer.errors)
result = serializer.save()
self.assertIsInstance(result, UniqueConstraintModel)