Standardize spelling to American English #9804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.endpoints = None | ||
|
|
||
| def _initialise_endpoints(self): | ||
| def _initialize_endpoints(self): |
There was a problem hiding this comment.
Unlike the others which are in documentation, this is an actual code change. Even if it's a private method, I'm not sure it's worth changing this...
If we do change it, I'd rather make it a separate change, to avoid us missing it while doing the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to DRF language-style the documentation should follow the american english style.
But I have found some British style words or inconsistent spellings like
behaviour,customise,initialise,e-mail,Sub-classesin the docs. In this PR I have modified them to DRF style.I have touched 26 files. and I can understand this is relatively large change. I'm not sure whether DRF team will like my approach or not. but if anything is there I'm happy to adjust.
Note:
highlight.pack.jswere intentionally not modified.