coroutine app factory #1184
Closed
coroutine app factory #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nevermind folks. It was late, I forgot how CMs work for some reason 😫 . This has to be one of the dumbest things I've ever implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR made no sense and is closed I'm leaving it up just for transparency.
This is a quick implementation of an idea that may be an alternative to #1152 and resolve #1151, or at least my use case for #1151 .
The idea is that if all we need is a context manager to handle lifespans, we don't need the app factory itself to be a context manager, just to be able to use a context manager