-
Notifications
You must be signed in to change notification settings - Fork 1
go: fix declaring multiple gateways #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fredr
wants to merge
1
commit into
v2
Choose a base branch
from
fredr/define-multi-gateway
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Verify that //encore:expose with a gateway name that hasn't been declared | ||
| # (and isn't the synthesized "api-gateway" default) is rejected. | ||
| ! parse | ||
| err 'exposed on undeclared gateway' | ||
|
|
||
| -- encore.app -- | ||
| {"edition": "2026"} | ||
|
|
||
| -- gw/encore.gateway.go -- | ||
| package gw | ||
|
|
||
| import "encore.dev/gateway" | ||
|
|
||
| var _ = gateway.New("api", gateway.Config{}) | ||
|
|
||
| -- svc/encore.service.go -- | ||
| package svc | ||
|
|
||
| import "encore.dev/service" | ||
|
|
||
| type MyService struct{} | ||
|
|
||
| var _ = service.New("svc", service.Config[MyService]{}) | ||
|
|
||
| -- svc/svc.go -- | ||
| package svc | ||
|
|
||
| import "context" | ||
|
|
||
| //encore:api path=/hello | ||
| //encore:expose gateway=does-not-exist | ||
| func Hello(ctx context.Context) error { return nil } | ||
| -- want: errors -- | ||
|
|
||
| ── Endpoint exposed on undeclared gateway ─────────────────────────────────────────────────[E9999]── | ||
|
|
||
| The endpoint is exposed on gateway "does-not-exist" via //encore:expose, but no gateway with that | ||
| name has been declared. | ||
|
|
||
| ╭─[ svc/svc.go:6:17 ] | ||
| │ | ||
| 4 │ | ||
| 5 │ //encore:api path=/hello | ||
| 6 │ //encore:expose gateway=does-not-exist | ||
| ⋮ ────────────────────── | ||
| 7 │ func Hello(ctx context.Context) error { return nil } | ||
| ───╯ | ||
|
|
||
| Add gateway.New("<name>", gateway.Config{}) in an encore.gateway.go file. The implicit | ||
| "api-gateway" name is only available when no gateways are declared at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Verify that a user-declared gateway with a non-default name works end-to-end: | ||
| # the endpoint's expose list should reference the user's gateway, and the | ||
| # implicit "api-gateway" should NOT be synthesized when any gateway is declared. | ||
| parse | ||
|
|
||
| -- encore.app -- | ||
| {"edition": "2026"} | ||
|
|
||
| -- gw/encore.gateway.go -- | ||
| package gw | ||
|
|
||
| import "encore.dev/gateway" | ||
|
|
||
| var _ = gateway.New("api", gateway.Config{}) | ||
|
|
||
| -- svc/encore.service.go -- | ||
| package svc | ||
|
|
||
| import "encore.dev/service" | ||
|
|
||
| type MyService struct{} | ||
|
|
||
| var _ = service.New("svc", service.Config[MyService]{}) | ||
|
|
||
| -- svc/svc.go -- | ||
| package svc | ||
|
|
||
| import "context" | ||
|
|
||
| //encore:api path=/hello | ||
| //encore:expose gateway=api | ||
| func Hello(ctx context.Context) error { return nil } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be emitted in the metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we should, but we insert it in two different places, so I just removed this one.
We add it in discoverGateways here:
encore-internal/v2/app/gateway_discovery.go
Line 20 in 39a5af6