Skip to content

docs: extend CLAUDE.md with migrated agent notes - #15

Merged
rubenhensen merged 2 commits into
mainfrom
chore/add-claude-md
Jul 15, 2026
Merged

docs: extend CLAUDE.md with migrated agent notes#15
rubenhensen merged 2 commits into
mainfrom
chore/add-claude-md

Conversation

@rubenhensen

Copy link
Copy Markdown

Extends the existing CLAUDE.md with agent notes migrated from the private dobby memory repo (encryption4all/dobby, formerly repos/<this-repo>/), verified against the current state of the code before migration.

Going forward this file is the single home for durable repo knowledge: dobby updates it in the same PR whenever it learns something worth keeping.

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating the agent notes into CLAUDE.md. One blocking factual error and one formatting nit.

The PR states these notes were "verified against the current state of the code", but the "No tests anywhere" claim (line 28) is wrong and internally contradicts line 75 of this same file, which cites test/windowConfig.test.js as a regression test. I verified against main: the backend has 4 #[test] fns in cryptify-back-end/src/main.rs (mod at line 469) and the frontend has 2 test files (9 tests pass via npm run test:electron), with package.json defining both test and test:electron scripts. Since this file is meant to be the durable knowledge home, a stale "no tests" note will steer future agents into skipping the suites — worth fixing before merge.

Rule check: no writing-rule violations of note (terse technical notes are fine); the orphan leading --- doubles as writing-rule encryption4all#46 (thematic break before a heading), flagged as the nit below.

Comment thread CLAUDE.md Outdated
Comment thread CLAUDE.md Outdated
@rubenhensen

Copy link
Copy Markdown
Author

/dobby fix all comments you made

- Replace the false 'No tests anywhere' note with the real suites and
  commands (cargo test; npm run test:electron), matching the file's own
  reference to test/windowConfig.test.js.
- Drop the dangling leading '---' rule (this is a new file, not an
  extension) and promote the section to a document H1.

Addresses the two review threads on this PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@dobby-coder dobby-coder Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper sign-off. Both cycle-1 items are resolved at 72fa294: the false "No tests anywhere" note is now the real suites and commands (backend cargo test, frontend npm run test:electron), and the orphan leading --- rule is gone, with the opening section promoted to a document H1. The review verified the doc claims against the code and both suites pass (9 frontend, 4 backend).

Rule check (writing-rules plus repo notes): clean. One minor, non-blocking observation: the Build/verify section uses bold on several inline list headers, a little above the target density. The emphasis reads fine for a scannable reference doc, so it does not block. Trim it later if you prefer.

Approving.

@rubenhensen
rubenhensen merged commit 795cebe into main Jul 15, 2026
@rubenhensen
rubenhensen deleted the chore/add-claude-md branch July 15, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant