ci: qualify both nginx config check names with their app - #156
Merged
Conversation
apps/outlook-addon and apps/website each had a job named `nginx config test`. A required status check is matched by name across the whole repository, so the two were indistinguishable to branch protection: requiring the name would cover both copies, and deleting either job would leave the name still reporting from the other — a gate that looks alive while covering half of what it names. Both were therefore left out of the required set added in #155. Only the display name changes. Both job ids stay `nginx`, so outlook-addon.yml's `needs: [check, test, urls, nginx]` still resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #155.
apps/outlook-addonandapps/websiteeach have a job namednginx config test, and a required status check is matched by name across the whole repository — so branch protection could not tell them apart. Both were left out of the required set in #155 for that reason; this makes them requireable.nginx config test→nginx config test (outlook-addon)— runsnginx -tagainstapps/outlook-addon/nginx/default.confinsidenginx:1.27-alpinenginx config test→nginx config test (website)— parsesdocker/nginx.dev.confanddocker/default.conf.templatewith crossplaneOnly the display
name:changes. Both job ids staynginx, sooutlook-addon.yml'sneeds: [check, test, urls, nginx]is untouched.The sharp edge, recorded in a comment on both jobs so neither gets "simplified" back: with a shared name, requiring it covers both copies, and deleting either job leaves the name still reporting from the other. The check would look alive while covering half of what you assume.
Both names go into the ruleset once this merges, bringing the required set to 20.
actionlintclean on both files — the three shellcheck findings it reports inwebsite.ymlare pre-existing and identical on unmodifiedmain.Part of encryption4all/postguard#247.