This repository was archived by the owner on Jul 28, 2026. It is now read-only.
chore(browser-detect): remove unused GetBrowserInfo() - #326
Merged
Conversation
The GetBrowserInfo() helper had no callers anywhere in src or tests. Remove it and drop it from the module export, leaving isMobile(). Closes #324 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
VERDICT: approve
Rules Dobby 2 sign-off — clean.
Verified the change against PR HEAD:
GetBrowserInfo()removed and dropped from the export;isMobileandexport { isMobile }are intact.grep -rn GetBrowserInfoacross the whole repo (src, tests, everywhere outside node_modules) returns zero matches — no orphaned callers, safe removal.- PR title is conventional-commit compliant and
pr-title.yml(semantic-pull-request) is present. - Reviewer assigned;
Closes #324present.
No rule findings and no review findings. Approving.
rubenhensen
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
GetBrowserInfo()helper fromsrc/lib/browser-detect.tsand drops it from the module export, leavingexport { isMobile }.A
grep -rn GetBrowserInfo src testsreturns no callers outside the definition and export, so nothing else needs to change.npm run check(0 errors) andnpm run test:unit(14 passed) both pass on the branch.Closes #324