ci: unignore the tracked JWT rotation fixtures so release-plz runs - #274
Merged
Conversation
Root .gitignore's `*.pem` matches the four fixtures #241 committed under pg-pkg/testdata/jwt_rotation/, leaving them tracked *and* ignored. release-plz refuses to run against a repo in that state, so delivery.yml's `Release-plz PR` job has failed on every push to main since #241 landed on 2026-07-16, twelve runs. `Release-plz release` is a separate job and was unaffected, which is why releases kept working and nothing looked broken. The visible damage is PR #187 (`chore: release`), still open and last updated 2026-07-16, so it is missing the version bumps and changelog entries for everything merged after that date. The negation is scoped to that one directory, so no other .pem is unignored. The fixtures are throwaway RSA keypairs for a single regression test and are already in history; this changes how git treats them, not what is committed. Closes #273
rubenhensen
added a commit
that referenced
this pull request
Jul 30, 2026
Brings in the 0.6.2/0.3.7/0.6.0/0.1.3 release (#187) and the .gitignore fix (#274). Two conflicts: - .gitignore: took main's wording, which is what #274 actually shipped. The spike carried an earlier, terser version of the same fix. - cryptify's pg-core requirement moved 0.6.1 -> 0.6.2 by hand. release-plz maintains these reqs on unpublished members too (pg-pkg carries one), but it could not touch cryptify's during #187 because cryptify was not yet a member. Merged rather than rebased on purpose: rebasing replays all 296 imported commits onto main and discards the subtree merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
.gitignore's*.pemmatches the four fixtures #241 committed underpg-pkg/testdata/jwt_rotation/, leaving them tracked and ignored. release-plz refuses to run against a repo in that state:So
delivery.yml'sRelease-plz PRjob has failed on every push tomainsince #241 landed on 2026-07-16. Twelve runs, most recently 30448113952.Release-plz releaseis a separate job and was unaffected, which is why releases kept tagging and nothing looked broken.The visible damage is PR #187 (
chore: release), still open and last updated 2026-07-16. It is missing the version bumps and changelog entries for everything merged after that date, including the wire-compat gate, COMPATIBILITY.md, cargo-semver-checks and the oasdiff gate.The change
One negation, scoped to that one directory so no other
.pemis unignored:The fixtures are throwaway RSA keypairs for
middleware::auth::tests::test_jwt_key_refresh_on_rotationand are already in history. This changes how git treats them, not what is committed.Verification
git ls-files -ci --exclude-standardis the check: it lists files that are both tracked and ignored, and onmainit returns those four. On this branch it returns nothing, andrelease-plz updategets past the working-directory check and starts resolving versions.Both were run locally against a clone of this branch and a control clone of
main.Not in this PR
Nothing in CI reports this class, so the same mistake can land again the same way. A step that fails when
git ls-files -ci --exclude-standardis non-empty would have caught it in #241's own PR. Left out here to keep the fix reviewable on its own; noted in #273.Closes #273