Skip to content

ci: unignore the tracked JWT rotation fixtures so release-plz runs - #274

Merged
rubenhensen merged 1 commit into
mainfrom
ci/unignore-jwt-rotation-fixtures
Jul 30, 2026
Merged

ci: unignore the tracked JWT rotation fixtures so release-plz runs#274
rubenhensen merged 1 commit into
mainfrom
ci/unignore-jwt-rotation-fixtures

Conversation

@rubenhensen

Copy link
Copy Markdown
Contributor

Root .gitignore's *.pem matches the four fixtures #241 committed under pg-pkg/testdata/jwt_rotation/, leaving them tracked and ignored. release-plz refuses to run against a repo in that state:

ERROR failed to update packages
  1: the working directory of this project has uncommitted changes. If these files
     are both committed and in .gitignore, either delete them or remove them from
     .gitignore.
     ["pg-pkg/testdata/jwt_rotation/priv_a.pem", …]

So delivery.yml's Release-plz PR job has failed on every push to main since #241 landed on 2026-07-16. Twelve runs, most recently 30448113952. Release-plz release is a separate job and was unaffected, which is why releases kept tagging and nothing looked broken.

The visible damage is PR #187 (chore: release), still open and last updated 2026-07-16. It is missing the version bumps and changelog entries for everything merged after that date, including the wire-compat gate, COMPATIBILITY.md, cargo-semver-checks and the oasdiff gate.

The change

One negation, scoped to that one directory so no other .pem is unignored:

!pg-pkg/testdata/jwt_rotation/*.pem

The fixtures are throwaway RSA keypairs for middleware::auth::tests::test_jwt_key_refresh_on_rotation and are already in history. This changes how git treats them, not what is committed.

Verification

git ls-files -ci --exclude-standard is the check: it lists files that are both tracked and ignored, and on main it returns those four. On this branch it returns nothing, and release-plz update gets past the working-directory check and starts resolving versions.

Both were run locally against a clone of this branch and a control clone of main.

Not in this PR

Nothing in CI reports this class, so the same mistake can land again the same way. A step that fails when git ls-files -ci --exclude-standard is non-empty would have caught it in #241's own PR. Left out here to keep the fix reviewable on its own; noted in #273.

Closes #273

Root .gitignore's `*.pem` matches the four fixtures #241 committed under
pg-pkg/testdata/jwt_rotation/, leaving them tracked *and* ignored. release-plz
refuses to run against a repo in that state, so delivery.yml's `Release-plz PR`
job has failed on every push to main since #241 landed on 2026-07-16, twelve
runs. `Release-plz release` is a separate job and was unaffected, which is why
releases kept working and nothing looked broken.

The visible damage is PR #187 (`chore: release`), still open and last updated
2026-07-16, so it is missing the version bumps and changelog entries for
everything merged after that date.

The negation is scoped to that one directory, so no other .pem is unignored.
The fixtures are throwaway RSA keypairs for a single regression test and are
already in history; this changes how git treats them, not what is committed.

Closes #273
@dobby-coder
dobby-coder Bot requested a review from leonbotros July 30, 2026 19:00
@rubenhensen
rubenhensen merged commit a55c6a0 into main Jul 30, 2026
30 checks passed
rubenhensen added a commit that referenced this pull request Jul 30, 2026
Brings in the 0.6.2/0.3.7/0.6.0/0.1.3 release (#187) and the .gitignore fix
(#274). Two conflicts:

- .gitignore: took main's wording, which is what #274 actually shipped. The
  spike carried an earlier, terser version of the same fix.
- cryptify's pg-core requirement moved 0.6.1 -> 0.6.2 by hand. release-plz
  maintains these reqs on unpublished members too (pg-pkg carries one), but it
  could not touch cryptify's during #187 because cryptify was not yet a member.

Merged rather than rebased on purpose: rebasing replays all 296 imported
commits onto main and discards the subtree merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release-plz PR job has been failing on main since #241 (tracked-and-ignored .pem fixtures)

1 participant