refactor: lint compliance, hybrid index support, and input validation#15
Merged
Conversation
Vaibhav-Endee
commented
Apr 16, 2026
Vaibhav-Endee
commented
Collaborator
- Rename exported identifiers to Go conventions (BaseUrl→BaseURL, JsonZip→JSONZip, SparseDim→SparseModel)
- Add godoc comments with trailing periods across all exported types and functions to satisfy revive/godot linters
- Expand golangci.yml with stricter linters (bodyclose, gocritic, godot, noctx, nlreturn, wrapcheck)
- Replace SparseDim int with SparseModel string and add IsHybrid bool flag to Index; enforce sparse data presence/absence at upsert time
- Add EfCon field to Index and propagate from IndexParams
- Add DenseRRFWeight and RRFRankConstant fields to QueryRequest
- Share HTTP client via idx.HTTP instead of allocating per-request; use http.NewRequestWithContext to satisfy noctx linter
- Validate upsert input: reject duplicate IDs and NaN/Inf vector values
- Wrap errors with fmt.Errorf + %w in compression.go
- Rename exported identifiers to Go conventions (BaseUrl→BaseURL, JsonZip→JSONZip, SparseDim→SparseModel) - Add godoc comments with trailing periods across all exported types and functions to satisfy revive/godot linters - Expand golangci.yml with stricter linters (bodyclose, gocritic, godot, noctx, nlreturn, wrapcheck) - Replace SparseDim int with SparseModel string and add IsHybrid bool flag to Index; enforce sparse data presence/absence at upsert time - Add EfCon field to Index and propagate from IndexParams - Add DenseRRFWeight and RRFRankConstant fields to QueryRequest - Share HTTP client via idx.HTTP instead of allocating per-request; use http.NewRequestWithContext to satisfy noctx linter - Validate upsert input: reject duplicate IDs and NaN/Inf vector values - Wrap errors with fmt.Errorf + %w in compression.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.