Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix movement bugs that break integration tests #32

Draft
wants to merge 3 commits into
base: experimental
Choose a base branch
from
Draft

Fix movement bugs that break integration tests #32

wants to merge 3 commits into from

Conversation

UnorderedSigh
Copy link

@UnorderedSigh UnorderedSigh commented Jul 6, 2023 •
edited
Loading

Bugfix: Fixes #29 and some related problems mentioned on Discord

Fix Details

  1. Different drag logic to fix allow stopping to work reliably, while also allowing lateral thrusters to work as intended.
  2. AI.cpp should use Command::Thrust(), not FORWARD and BACK.

Testing Done

Ran the integration tests. Flew around a bit.

I ran the failing integration test ten times on an Ubuntu 22 GL build, and it passed.

@UnorderedSigh
Copy link
Author

No, no, apparently another test is failing now.

@UnorderedSigh
Copy link
Author

Test #67: Test-Framework - Navigate is failing with a watchdog timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect logic in Ship::Move breaks Command::STOP
1 participant
@UnorderedSigh