Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Expanding Alpha Centauri, and rearranging to be circumstellar rather than circumbinary #73

Merged

Conversation

Quantumshark
Copy link

Content

Same changes as #66, but not broken.

Summary

Larger, semi-real scaled Alpha Centauri (obviously, it's not possible to get it 100% accurate as there isn't support for elliptical orbits), with the planets orbiting the stars individually rather than both stars in the middle.

Ramscoop and solar collection will work weirdly until someone fixes the code to make them work from each star separately rather than the current approach of summing them across all stars and emanating all that from the centre of the system.

Screenshots

image
image
image

Testing Done

Went to the system and looked at it to check that the planets were in the right places

Save File

This save file can be used to test these changes:
Any; just visit Alpha Centauri

Performance Impact

Asteroid belt feels like it might be an issue, but it's less dense than the one you've got in Sol and I'm not aware of that one being a problem.

@Zitchas
Copy link
Member

Zitchas commented Jul 23, 2024

Thanks for reposting.

Just as an aside for myself and anyone curious in the future, the wikipedia article on Alpha Centauri:
https://en.wikipedia.org/wiki/Alpha_Centauri

@Zitchas Zitchas added the Content (data) The information that the game uses to make everything label Jul 23, 2024
@Zitchas
Copy link
Member

Zitchas commented Aug 1, 2024

I should be able to test this at some point this week, sorry for taking a bit to get to it.

Could you update it please?

If it's OK with you I can just hit the "update branch" button, but I don't want to risk breaking anything if you're using this branch elsewhere too.

@Quantumshark
Copy link
Author

I hadn't noticed the update branch button before, so thank you for pointing it out.

@Zitchas
Copy link
Member

Zitchas commented Aug 1, 2024

You are welcome! And thank you for updating.

@Zitchas
Copy link
Member

Zitchas commented Aug 12, 2024

Sorry it's taken me longer than expected to get to this. Thanks for updating!

@TheGiraffe3
Copy link

@Zitchas what's the status on this?

@Zitchas
Copy link
Member

Zitchas commented Sep 12, 2024

The status is "waiting for me to have the capability and time to sit down and play it."

First I didn't have time, then I didn't have the capability to build it due to software failures. And then didn't have the capability due to hardware failures. So the delay is all on me at this point.

@Quantumshark
Copy link
Author

No worries, these things take as long as they take.

And, feel free to hit the update branch button yourself when you've got time rather than waiting on me.

@Zitchas
Copy link
Member

Zitchas commented Sep 30, 2024

OK, this will be tested within the next 24h. For sure this time. sigh

Copy link

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've retested. It certainly makes Alpha Centauri feel a lot bigger, and the player's (and others') ships a lot smaller.

and no, I definitely didn't test by demanding tribute

@Zitchas
Copy link
Member

Zitchas commented Sep 30, 2024

OK, I've finally tested it. Thanks for your patience, Quantumshark.

My thoughts:
a) To start off, it feels a bit disconcerting. Going to the center of the system, and finding... nothing there. Which is really unusual for ES, but is fitting Alpha Centauri's tri-star system. (and just to be clear, disconcerting is not a bad thing)
b) Flying around to find the stars and planets makes the system feel big. Just flying from one star to the other in a shuttle was about 38 seconds. Which feels like forever, but is really not that long.
c) Space. As in, there's space for stuff to happen here. I can imagine a lot of possibilities to have something going on in each half of the system, have convoys going back and forth, etc.

All in all, I like it.

@Zitchas
Copy link
Member

Zitchas commented Sep 30, 2024

One thing in regards to the asteroid belt... It's very sparse and hard to really notice. I had trouble locating it.

edit: I eventually added a x10 to the strength of asteroid scanners, sold my HD, and loaded up my shuttle with 8 of them in order to see where the ring was. It's probably in a good location, but probably needs to be a bit more dense and/or more valuable, or the generic asteroids need to be removed. Right now, the generic ones are just dense enough to render the meaningful asteroids hard to distinguish a pattern.

Copy link
Member

@Zitchas Zitchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can tweak it more in the future, but I'm satisfied it's good enough to merge and include alongside other experiments.

Thanks!

@Zitchas Zitchas merged commit 3ba24b6 into endless-sky:experimental Sep 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content (data) The information that the game uses to make everything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants