Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the Random Stock PR #24

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

TheGiraffe3
Copy link
Contributor

@TheGiraffe3 TheGiraffe3 commented Jun 24, 2024

New feature

#10265

Summary

This PR adds the information for #10265 at the main repository.

@TheGiraffe3
Copy link
Contributor Author

@Zarkonnen I’m not sure how to document the event adding and removing shipyards/outfitters. Can you help with that/add that?

@Zarkonnen
Copy link
Contributor

@Zarkonnen I’m not sure how to document the event adding and removing shipyards/outfitters. Can you help with that/add that?

Will do so later today. :)

@Zarkonnen
Copy link
Contributor

FFS I have no idea how to use any of this github stuff. How do I add suggested changes?

@TheGiraffe3
Copy link
Contributor Author

TheGiraffe3 commented Jun 25, 2024

I'll change it for the newly changed "shipyard stock"/"outfitter stock". You can click to the left side of the file, on the number, to suggest changes.
Also, you (should) have write access to this branch, so you can change files to be the way you want.

@mOctave
Copy link
Contributor

mOctave commented Jun 25, 2024

FFS I have no idea how to use any of this github stuff. How do I add suggested changes?

Go to "files changed"
Screenshot 2024-06-25 at 11 32 14 AM
Find the line you want to suggest changes on, and hit the plus button
Screenshot 2024-06-25 at 11 32 34 AM
Click the +- button on the file icon
Screenshot 2024-06-25 at 11 32 39 AM
And then, add a single comment, or start a review if you have multiple suggestions

@TheGiraffe3
Copy link
Contributor Author

@Zarkonnen can you take another look at this and review/edit it?

wiki/CreatingSales.md Outdated Show resolved Hide resolved
wiki/CreatingSales.md Outdated Show resolved Hide resolved
wiki/CreatingSales.md Outdated Show resolved Hide resolved
@TheGiraffe3 TheGiraffe3 marked this pull request as ready for review July 21, 2024 07:57
@warp-core warp-core added the enhancement Adding documentation about a new feature being PR'd to endless-sky/endless-sky label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding documentation about a new feature being PR'd to endless-sky/endless-sky
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants