-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardened262): Preliminary harness #2593
Draft
kriskowal
wants to merge
15
commits into
master
Choose a base branch
from
kriskowal-hardened262
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
0bc22aa
to
7780d08
Compare
ad97c34
to
f610e34
Compare
7780d08
to
ffe0174
Compare
eb25995
to
9db3161
Compare
f610e34
to
315c521
Compare
2e28e44
to
00b60a3
Compare
315c521
to
3417669
Compare
00b60a3
to
fda6c75
Compare
3417669
to
6d709e7
Compare
6d709e7
to
f388ca5
Compare
fda6c75
to
e454344
Compare
f388ca5
to
89fae49
Compare
52b9f46
to
db5bd80
Compare
…3fc26e26084d7b36976d95e8211a
b8149b7
to
52598c1
Compare
db5bd80
to
1750673
Compare
da44206
to
bd79347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #400, #2259
Individually reviewable commits, mostly large and mechanical.
Description
Introduces a harness for test262 style tests for Hardened JavaScript, toward verifying parity between SES and SES specialized for native Hardened JavaScript on XS.
The harness relies on
test262-stream
to discover test files but parts ways withtest262-harness
so that it can:The chief difficulty that motivates going our own way with this harness is that we need the Node.js agent to shim ModuleSource through an ordinary Node.js import, which is difficult to force into the shape of a test preamble that gets injected into each case. Similarly, we must generate a shim for XS, using our own Endo tooling that recognizes package conditions. And we need our own agents for Lockdown and Compartment variations and test262-harness does not support agent plugins.
For this preliminary PR, I’ve subsumed Moddable’s test262 tests only. Subsequent changes will introduce more tests SES parity.