-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resque scheduler #93
Resque scheduler #93
Conversation
0ccb8f5
to
3063417
Compare
3063417
to
424490e
Compare
@@ -0,0 +1 @@ | |||
include_recipe 'resque' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be include_recipe 'resque_scheduler'
The main 'resque-scheduler' recipe has the following code:
Which comes from the v4 recipe. According to engineyard/ey-cloud-recipes#150 that codes is faulty and evaluates to '1', which is why the gems get never installed. Shall the aforemenationed code be dropped from the main 'resque-scheduler' recipe? |
@dvalfre I agree, the gem dependencies should be in the Gemfile and the recipe should not bother with installing the gems. |
@@ -0,0 +1 @@ | |||
default['redis']['utility_name'] = 'resque' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a clustered env, this line should be replaced with at least:
default['redis'].tap do |redis|
# Collect the redis instances in this array
redis_instances = []
# Run Redis on a named util instance
# This is the default
redis['utility_name'] = 'resque'
redis_instances << redis['utility_name']
redis['is_redis_instance'] = (
node['dna']['instance_role'] == 'util' &&
redis_instances.include?(node['dna']['name'])
)
end
and for a solo env with:
default['redis'].tap do |redis|
# Collect the redis instances in this array
redis_instances = []
# Run redis on a solo instance
# Not recommended for production environments
#redis['is_redis_instance'] = (node['dna']['instance_role'] == 'solo')
end
@@ -0,0 +1,3 @@ | |||
# Custom Redis | |||
|
|||
This custom-redis recipe is used in the resque example to install redis on the utility instance named "resque" instead of the default "redis". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we include this small Redis wrapper at all? Leaning towards adding a section on the Resque-Scheduler wrapper's Readme telling the customer to enable the full Redis recipe (as we do with Sidekiq).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened PR #150 to remove custom-redis from resque_scheduler
Uses Joe Heth's code from #75