-
Notifications
You must be signed in to change notification settings - Fork 328
ENSv2 readiness guide #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schmidsi
wants to merge
14
commits into
master
Choose a base branch
from
ensv2-readyness
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ens-docs with
|
| Latest commit: |
a6f7609
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f605a376.docs-bao.pages.dev |
| Branch Preview URL: | https://ensv2-readyness.docs-bao.pages.dev |
gskril
reviewed
Nov 2, 2025
schmidsi
commented
Nov 3, 2025
schmidsi
commented
Nov 3, 2025
gskril
reviewed
Nov 3, 2025
- Fix grammar: "just update" → "just updating" - Replace "according" with "appropriate" for better clarity - Fix typo: "will introduction" → "will introduce" - Fix grammar: "an integrations" → "an integration" - Fix localhost URL to use relative path 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add context about ENSv2 and Namechain as primary L2 - Convert formal tone to conversational "you" style throughout - Break complex sentences into shorter, punchier ones - Change passive voice to active voice - Rename generic "Test" headers to descriptive ones - Clarify that supported libraries handle everything automatically - Position technical sections as educational rather than required steps - Fix CCIP Read link 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Explain importance of detecting DNS names alongside .eth names - Show common mistake: regex that only matches .eth domains - Provide correct regex pattern for matching all valid domains - Add info callout recommending library use over custom regex - Include real examples: ensfairy.xyz and ses.fkey.id - Link to DNS integration documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Explain that ENS resolution always uses Mainnet even on L2s - Show how to configure both L2 (Base) and Mainnet together - Provide code examples for Wagmi, Viem, and Ethers - Use library defaults instead of specific RPC URLs - Clarify that Wagmi auto-uses Mainnet for ENS resolution - Show explicit mainnet client usage for Viem and Ethers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Show how to resolve Base addresses from ENS names - Add Wagmi hook example with useEnsAddress and chainId - Add Viem example using coinType for Base - Add Ethers example using getResolver and getAddress - Focus examples on L2-specific address resolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
d955ae9 to
5ca047c
Compare
- Explicit about web3 libraries - Clarify Universal Resolver proxy contract - Easier DNS naming - Emoji example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at an ENSv2 readiness guide: