Skip to content

a11y: add aria-label to icon-only buttons #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wmagev wants to merge 1 commit into
base: test
Choose a base branch
from
Open

a11y: add aria-label to icon-only buttons #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/dashboard/EventFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ const EventFeed: React.FC = () => {
{scrolled && (
<Button
onClick={scrollToTop}
aria-label="Scroll to top"
size="small"
sx={{
position: 'absolute',
Expand Down
6 changes: 5 additions & 1 deletion src/components/dashboard/OrderbookDepth.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,11 @@ const OrderbookDepth: React.FC = () => {
arrow
placement="right"
>
<IconButton size="small" sx={{ p: 0, color: 'text.secondary' }}>
<IconButton
aria-label="Orderbook info"
size="small"
sx={{ p: 0, color: 'text.secondary' }}
>
<InfoOutlinedIcon fontSize="small" />
</IconButton>
</Tooltip>
Expand Down
4 changes: 2 additions & 2 deletions src/components/layout/AppLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ const AppLayout: React.FC = () => {
<Stack
sx={{
width: '100vw',
minHeight: '100vh',
height: '100vh',
minHeight: '100dvh',
height: '100dvh',
overflow: 'hidden',
justifyContent: 'center',
}}
Expand Down
4 changes: 3 additions & 1 deletion src/pages/DashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const DashboardPage: React.FC = () => {
/>
<Stack
sx={{
minHeight: '100vh',
minHeight: '100dvh',
backgroundColor: 'background.default',
px: { xs: 1.5, sm: 2, md: 4 },
py: { xs: 2, sm: 3, md: 4 },
Expand Down Expand Up @@ -70,6 +70,7 @@ const DashboardPage: React.FC = () => {
href={docsUrl}
target="_blank"
rel="noopener noreferrer"
aria-label="Documentation"
sx={{
color: 'text.secondary',
border: '1px solid',
Expand All @@ -88,6 +89,7 @@ const DashboardPage: React.FC = () => {
</Tooltip>
<IconButton
onClick={toggleTheme}
aria-label={mode === 'light' ? 'Switch to dark mode' : 'Switch to light mode'}
sx={{
color: 'text.secondary',
border: '1px solid',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/NotFoundPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const NotFoundPage: React.FC = () => (
<Box
sx={{
width: '100vw',
height: '100vh',
height: '100dvh',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/SwapDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ const SwapDetailPage: React.FC = () => {
const PageWrapper: React.FC<{ children: React.ReactNode }> = ({ children }) => (
<Stack
sx={{
minHeight: '100vh',
minHeight: '100dvh',
backgroundColor: 'background.default',
px: { xs: 1.5, sm: 2, md: 4 },
py: { xs: 2, sm: 3, md: 4 },
Expand Down