Skip to content

fix(miners): normalize join conditions in getPullRequestsByRepo to LOWER() for case-insensitive repo matching #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tet-9 wants to merge 1 commit into from
Closed

fix(miners): normalize join conditions in getPullRequestsByRepo to LOWER() for case-insensitive repo matching #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/das/src/api/miners/miners.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ export class MinersService {
SELECT${PR_SELECT_COLUMNS}
FROM pull_requests p
LEFT JOIN pr_review_summary rs
ON rs.repo_full_name = p.repo_full_name
ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name)
AND rs.pr_number = p.pr_number
LEFT JOIN repos r
ON r.repo_full_name = p.repo_full_name
ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name)
WHERE p.author_github_id = $1
AND (
(p.state = 'OPEN' AND p.created_at >= $2)
Expand Down Expand Up @@ -234,10 +234,10 @@ export class MinersService {
JOIN windows w
ON w.repo_full_name = LOWER(p.repo_full_name)
LEFT JOIN pr_review_summary rs
ON rs.repo_full_name = p.repo_full_name
ON LOWER(rs.repo_full_name) = LOWER(p.repo_full_name)
AND rs.pr_number = p.pr_number
LEFT JOIN repos r
ON r.repo_full_name = p.repo_full_name
ON LOWER(r.repo_full_name) = LOWER(p.repo_full_name)
WHERE p.author_github_id = $1
AND (
(p.state = 'OPEN' AND p.created_at >= w.since)
Expand Down
Loading