Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/components/FilterButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,41 @@ const FilterButton: React.FC<FilterButtonProps> = ({
onClick={onClick}
fullWidth={fullWidth}
sx={{
display: 'inline-flex',
alignItems: 'center',
justifyContent: 'center',
gap: 0.75,
lineHeight: 1.2,
color: isActive ? activeTextColor : (t) => t.palette.text.secondary,
backgroundColor: isActive ? 'surface.light' : 'surface.transparent',
borderRadius: '6px',
px: { xs: 1, sm: 1.5 },
py: { xs: 0.5, sm: 0.75 },
px: { xs: 1.25, sm: 1.5 },
py: { xs: 0.5, sm: 0.65 },
minHeight: 32,
minWidth: fullWidth ? 0 : 'auto',
textTransform: 'none',
fontSize: { xs: '0.65rem', sm: '0.75rem' },
fontSize: { xs: '0.7rem', sm: '0.75rem' },
fontWeight: isActive ? 600 : 500,
border: isActive ? `1px solid ${color}` : '1px solid transparent',
whiteSpace: 'nowrap',
'&:hover': {
backgroundColor: 'border.light',
},
}}
>
{label}{' '}
<Box component="span" sx={{ display: 'inline-flex', alignItems: 'center' }}>
{label}
</Box>
{count !== undefined && (
<Box
component="span"
sx={{
opacity: 0.6,
ml: '6px',
fontSize: { xs: '0.6rem', sm: '0.7rem' },
display: 'inline-flex',
alignItems: 'center',
opacity: 0.72,
fontWeight: 600,
fontVariantNumeric: 'tabular-nums',
fontSize: 'inherit',
}}
>
{count}
Expand Down
180 changes: 161 additions & 19 deletions src/components/repositories/RepositoryIssuesTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@ import {
Typography,
alpha,
useTheme,
TextField,
InputAdornment,
IconButton,
useMediaQuery,
} from '@mui/material';
import CheckCircleIcon from '@mui/icons-material/CheckCircle';
import RadioButtonUncheckedIcon from '@mui/icons-material/RadioButtonUnchecked';
import ArrowForwardIcon from '@mui/icons-material/ArrowForward';
import SearchIcon from '@mui/icons-material/Search';
import {
useRepositoryIssues,
useRepoIssues,
Expand All @@ -32,6 +37,7 @@ import {
} from '../../utils/issueStatus';
import { STATUS_COLORS, TEXT_OPACITY, scrollbarSx } from '../../theme';
import FilterButton from '../FilterButton';
import { ClearSearchAdornment } from '../common/ClearSearchAdornment';
import TablePagination from '../../components/common/TablePagination';

interface RepositoryIssuesTableProps {
Expand All @@ -51,6 +57,24 @@ type RepoIssuesFilter = 'all' | 'open' | 'closed';
const isRepoIssuesFilter = (v: unknown): v is RepoIssuesFilter =>
v === 'all' || v === 'open' || v === 'closed';

function issueMatchesSearch(
issue: RepositoryIssue,
searchQuery: string,
): boolean {
const q = searchQuery.trim().toLowerCase();
if (!q) return true;
const title = getLowerText(issue.title);
if (title.includes(q)) return true;
const author = (issue.authorLogin || issue.author || '').toLowerCase();
if (author.includes(q)) return true;
const numStr = String(issue.number);
if (numStr.includes(q)) return true;
if (q.startsWith('#')) {
const rest = q.slice(1).trim();
if (rest && numStr.includes(rest)) return true;
}
return false;
}
const ISSUE_PAGE_SIZE = 20;

const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
Expand All @@ -66,16 +90,27 @@ const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
);
const [sortKey, setSortKey] = useState<SortKey>('number');
const [sortDirection, setSortDirection] = useState<SortOrder>('desc');
const [searchQuery, setSearchQuery] = useState('');
const [mobileSearchOpen, setMobileSearchOpen] = useState(false);
const isSmDown = useMediaQuery(theme.breakpoints.down('sm'));

useEffect(() => {
setSearchQuery('');
setMobileSearchOpen(false);
}, [repositoryFullName]);

const [page, setPage] = useState(0);

const counts = useMemo(() => {
if (!issues) return { total: 0, open: 0, closed: 0 };
const match = (issue: RepositoryIssue) =>
issueMatchesSearch(issue, searchQuery);
return {
total: issues.length,
open: issues.filter((issue) => !issue.closedAt).length,
closed: issues.filter((issue) => issue.closedAt).length,
total: issues.filter(match).length,
open: issues.filter((issue) => !issue.closedAt).filter(match).length,
closed: issues.filter((issue) => issue.closedAt).filter(match).length,
};
}, [issues]);
}, [issues, searchQuery]);

const filteredIssues = useMemo(() => {
if (!issues) return [];
Expand All @@ -84,13 +119,19 @@ const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
return issues;
}, [issues, filter]);

const searchFilteredIssues = useMemo(() => {
return filteredIssues.filter((issue) =>
issueMatchesSearch(issue, searchQuery),
);
}, [filteredIssues, searchQuery]);

const sortedIssues = useMemo(() => {
const directionFactor = sortDirection === 'asc' ? 1 : -1;
const collator = new Intl.Collator(undefined, {
sensitivity: 'base',
numeric: true,
});
const decorated = filteredIssues.map((issue) => {
const decorated = searchFilteredIssues.map((issue) => {
let value: number | string;
switch (sortKey) {
case 'number':
Expand Down Expand Up @@ -126,7 +167,7 @@ const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
);
});
return decorated.map((item) => item.issue);
}, [filteredIssues, sortKey, sortDirection]);
}, [searchFilteredIssues, sortKey, sortDirection]);

// Reset to the first page whenever the result set changes underneath us.
useEffect(() => {
Expand Down Expand Up @@ -306,27 +347,124 @@ const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
const headerToolbar = (
<Box
sx={{
p: 3,
p: { xs: 2, sm: 3 },
borderBottom: `1px solid ${theme.palette.border.light}`,
display: 'flex',
justifyContent: 'space-between',
alignItems: 'center',
flexWrap: 'wrap',
gap: 2,
flexDirection: 'column',
gap: { xs: 1.5, sm: 2 },
}}
>
<Typography
variant="h6"
sx={{ color: 'text.primary', fontSize: '1.1rem', fontWeight: 500 }}
<Box
sx={{
display: 'flex',
flexDirection: { xs: 'column', sm: 'row' },
alignItems: { xs: 'stretch', sm: 'center' },
justifyContent: 'space-between',
gap: { xs: 1.5, sm: 2 },
width: '100%',
}}
>
Issues ({sortedIssues.length})
</Typography>
<Box
sx={{
display: 'flex',
alignItems: 'center',
justifyContent: 'space-between',
gap: 1,
minWidth: 0,
flex: { sm: '1 1 auto' },
}}
>
<Typography
variant="h6"
sx={{
color: 'text.primary',
fontSize: { xs: '1rem', sm: '1.1rem' },
fontWeight: 500,
minWidth: 0,
}}
>
Issues ({sortedIssues.length})
</Typography>
{isSmDown && !mobileSearchOpen ? (
<IconButton
size="small"
aria-label="Search issues"
onClick={() => setMobileSearchOpen(true)}
sx={{
flexShrink: 0,
border: '1px solid',
borderColor: 'border.light',
borderRadius: 2,
color: 'text.secondary',
}}
>
<SearchIcon fontSize="small" />
</IconButton>
) : null}
</Box>
{(!isSmDown || mobileSearchOpen) && (
<TextField
size="small"
placeholder="Search (#, title, author)…"
value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)}
onKeyDown={(e) => {
if (
e.key === 'Escape' &&
!searchQuery.trim() &&
isSmDown &&
mobileSearchOpen
) {
setMobileSearchOpen(false);
}
}}
onBlur={() => {
if (isSmDown && !searchQuery.trim()) {
setMobileSearchOpen(false);
}
}}
autoFocus={Boolean(isSmDown && mobileSearchOpen)}
InputProps={{
startAdornment: (
<InputAdornment position="start">
<SearchIcon
sx={{
color: 'text.secondary',
fontSize: '1rem',
}}
/>
</InputAdornment>
),
endAdornment: (
<ClearSearchAdornment
visible={Boolean(searchQuery)}
onClear={() => setSearchQuery('')}
/>
),
}}
sx={{
width: { xs: '100%', sm: 280 },
maxWidth: { xs: '100%', sm: 360 },
flexShrink: 0,
alignSelf: { xs: 'stretch', sm: 'auto' },
'& .MuiOutlinedInput-root': {
fontSize: '0.8rem',
backgroundColor: 'surface.subtle',
borderRadius: 2,
'& fieldset': { borderColor: 'border.light' },
'&:hover fieldset': { borderColor: 'border.medium' },
'&.Mui-focused fieldset': { borderColor: 'primary.main' },
},
}}
/>
)}
</Box>
<Stack
direction="row"
spacing={1}
flexWrap="wrap"
useFlexGap
sx={{ rowGap: 1 }}
spacing={1}
sx={{ columnGap: 1, rowGap: 1 }}
>
<FilterButton
label="All"
Expand Down Expand Up @@ -538,7 +676,11 @@ const RepositoryIssuesTable: React.FC<RepositoryIssuesTableProps> = ({
fontSize: '0.9rem',
}}
>
No issues found
{searchQuery.trim() &&
sortedIssues.length === 0 &&
filteredIssues.length > 0
? 'No issues match your search.'
: 'No issues found'}
</Typography>
</Box>
}
Expand Down
Loading